Re: [dpdk-dev] [PATCH v4 4/4] app/test-pmd: test tunnel filter for IP in GRE

["De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>]

Hi Xutao,

> -----Original Message-----
> From: Sun, Xutao
> Sent: Thursday, February 18, 2016 9:58 AM
> To: dev@dpdk.org
> Cc: Zhang, Helin; Wu, Jingjing; De Lara Guarch, Pablo; Sun, Xutao; Liu, Jijiang
> Subject: [PATCH v4 4/4] app/test-pmd: test tunnel filter for IP in GRE
> 
> This patch add some options in tunnel_filter command to test IP in GRE
> packet classification on i40e.
> 
> Signed-off-by: Xutao Sun <xutao.sun@intel.com>
> Signed-off-by: Jijiang Liu <jijiang.liu@intel.com>

Sorry, I see your point now, that the tunnel/filter types are not being specified in the testpmd documentation.
But actually, I think it would be a good idea to enumerate the different types in that document as well
(and maybe add a description like "set fwd").

Plus, see one extra comment below.

> ---
>  app/test-pmd/cmdline.c | 36 ++++++++++++++++++++++++------------
>  1 file changed, 24 insertions(+), 12 deletions(-)
> 
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index c707318..6a5cd9f 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -301,12 +301,14 @@ static void cmd_help_long_parsed(void
> *parsed_result,
>  			"    Set the outer VLAN TPID for Packet Filtering on"
>  			" a port\n\n"
> 
> -			"tunnel_filter add (port_id) (outer_mac) (inner_mac)
> (ip_addr) "
> -			"(inner_vlan) (vxlan|nvgre) (filter_type) (tenant_id)
> (queue_id)\n"
> +			"tunnel_filter add (port_id) (outer_mac) (inner_mac)
> (ip_addr)"
> +			"(inner_vlan) (vxlan|nvgre|iningre) (filter_type)"

Should be ipingre?

> +			"(tenant_id) (queue_id)\n"
>  			"   add a tunnel filter of a port.\n\n"
> 
> -			"tunnel_filter rm (port_id) (outer_mac) (inner_mac)
> (ip_addr) "
> -			"(inner_vlan) (vxlan|nvgre) (filter_type) (tenant_id)
> (queue_id)\n"
> +			"tunnel_filter rm (port_id) (outer_mac) (inner_mac)
> (ip_addr)"
> +			"(inner_vlan) (vxlan|nvgre|ipingre) (filter_type)"
> +			"(tenant_id) (queue_id)\n"
>  			"   remove a tunnel filter of a port.\n\n"
>