From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 22D8B93FA for ; Thu, 18 Feb 2016 13:16:49 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP; 18 Feb 2016 04:16:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,465,1449561600"; d="scan'208";a="654975136" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by FMSMGA003.fm.intel.com with ESMTP; 18 Feb 2016 04:16:46 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.102]) by IRSMSX154.ger.corp.intel.com ([169.254.12.208]) with mapi id 14.03.0248.002; Thu, 18 Feb 2016 12:16:46 +0000 From: "De Lara Guarch, Pablo" To: "Sun, Xutao" , "dev@dpdk.org" Thread-Topic: [PATCH v4 4/4] app/test-pmd: test tunnel filter for IP in GRE Thread-Index: AQHRajL1hMtCXT4GakG7VW6m+7/eyZ8xtwmQ Date: Thu, 18 Feb 2016 12:16:45 +0000 Message-ID: References: <1453976778-27807-1-git-send-email-xutao.sun@intel.com> <1455789499-15975-1-git-send-email-xutao.sun@intel.com> <1455789499-15975-5-git-send-email-xutao.sun@intel.com> In-Reply-To: <1455789499-15975-5-git-send-email-xutao.sun@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWE4NDM2MmMtYjM4Yy00N2RkLTllMDctN2U3YjJiNDMxNDFjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlhYNUdaczQzelVuN0RmTmkrMjdcL1lGQkcyd2l0U1FtRlwvVU5QTEVpTWJYaz0ifQ== x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 4/4] app/test-pmd: test tunnel filter for IP in GRE X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Feb 2016 12:16:50 -0000 Hi Xutao, > -----Original Message----- > From: Sun, Xutao > Sent: Thursday, February 18, 2016 9:58 AM > To: dev@dpdk.org > Cc: Zhang, Helin; Wu, Jingjing; De Lara Guarch, Pablo; Sun, Xutao; Liu, J= ijiang > Subject: [PATCH v4 4/4] app/test-pmd: test tunnel filter for IP in GRE >=20 > This patch add some options in tunnel_filter command to test IP in GRE > packet classification on i40e. >=20 > Signed-off-by: Xutao Sun > Signed-off-by: Jijiang Liu Sorry, I see your point now, that the tunnel/filter types are not being spe= cified in the testpmd documentation. But actually, I think it would be a good idea to enumerate the different ty= pes in that document as well (and maybe add a description like "set fwd"). Plus, see one extra comment below. > --- > app/test-pmd/cmdline.c | 36 ++++++++++++++++++++++++------------ > 1 file changed, 24 insertions(+), 12 deletions(-) >=20 > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index c707318..6a5cd9f 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -301,12 +301,14 @@ static void cmd_help_long_parsed(void > *parsed_result, > " Set the outer VLAN TPID for Packet Filtering on" > " a port\n\n" >=20 > - "tunnel_filter add (port_id) (outer_mac) (inner_mac) > (ip_addr) " > - "(inner_vlan) (vxlan|nvgre) (filter_type) (tenant_id) > (queue_id)\n" > + "tunnel_filter add (port_id) (outer_mac) (inner_mac) > (ip_addr)" > + "(inner_vlan) (vxlan|nvgre|iningre) (filter_type)" Should be ipingre? > + "(tenant_id) (queue_id)\n" > " add a tunnel filter of a port.\n\n" >=20 > - "tunnel_filter rm (port_id) (outer_mac) (inner_mac) > (ip_addr) " > - "(inner_vlan) (vxlan|nvgre) (filter_type) (tenant_id) > (queue_id)\n" > + "tunnel_filter rm (port_id) (outer_mac) (inner_mac) > (ip_addr)" > + "(inner_vlan) (vxlan|nvgre|ipingre) (filter_type)" > + "(tenant_id) (queue_id)\n" > " remove a tunnel filter of a port.\n\n" >=20