From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id BEF471DB1 for ; Wed, 2 Mar 2016 12:04:39 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP; 02 Mar 2016 03:04:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,528,1449561600"; d="scan'208";a="925077141" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga002.jf.intel.com with ESMTP; 02 Mar 2016 03:04:38 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.102]) by IRSMSX102.ger.corp.intel.com ([169.254.2.19]) with mapi id 14.03.0248.002; Wed, 2 Mar 2016 11:04:37 +0000 From: "De Lara Guarch, Pablo" To: Stephen Hurd , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] app/testpmd Fix max_socket detection Thread-Index: AQHRTlEc0v0upWFEWke0JvbqpUUa7p9GSeMg Date: Wed, 2 Mar 2016 11:04:36 +0000 Message-ID: References: <24888901-A45C-4E23-871E-3485AF2423D2@intel.com> <1452723816-73141-1-git-send-email-shurd@broadcom.com> In-Reply-To: <1452723816-73141-1-git-send-email-shurd@broadcom.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDlmNTJjMjEtODMwMS00MDE4LThjMDItZGMyNTViZDUzYmU3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Ilc0Y0FzRUp6VW1HalpcL1c5VWJvbGlIVTQzdkdjNWdvSmdvOGFIeHBWVFI0PSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd Fix max_socket detection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Mar 2016 11:04:40 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hurd > Sent: Wednesday, January 13, 2016 10:24 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2] app/testpmd Fix max_socket detection >=20 > Previously, max_socket was set to the highest numbered socket with > an enabled lcore. The intent is to set it to the highest socket > regardless of it being enabled. >=20 > Change-Id: I6306af0f90aa3c1fc5ffed75d1eed8297d29e132 > Signed-off-by: Stephen Hurd >=20 > v2: Forgot to commit before sending email... sorry for the nouse. > --- > app/test-pmd/testpmd.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) >=20 > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index 6129c26..a4088f9 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -359,17 +359,17 @@ set_default_fwd_lcores_config(void) >=20 > nb_lc =3D 0; > for (i =3D 0; i < RTE_MAX_LCORE; i++) { > - if (! rte_lcore_is_enabled(i)) > - continue; > - if (i =3D=3D rte_get_master_lcore()) > - continue; > - fwd_lcores_cpuids[nb_lc++] =3D i; > sock_num =3D rte_lcore_to_socket_id(i) + 1; > if (sock_num > max_socket) { > if (sock_num > RTE_MAX_NUMA_NODES) > rte_exit(EXIT_FAILURE, "Total sockets greater > than %u\n", RTE_MAX_NUMA_NODES); > max_socket =3D sock_num; > } > + if (! rte_lcore_is_enabled(i)) > + continue; > + if (i =3D=3D rte_get_master_lcore()) > + continue; > + fwd_lcores_cpuids[nb_lc++] =3D i; > } > nb_lcores =3D (lcoreid_t) nb_lc; > nb_cfg_lcores =3D nb_lcores; > -- > 1.9.1 Acked-by: Pablo de Lara