From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Griffin, John" <john.griffin@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 0/3] AES GCM, AES CMAC fixes and addition of GCM tests for QAT.
Date: Thu, 10 Mar 2016 17:28:54 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8973C8C8122@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1457454137-22315-1-git-send-email-john.griffin@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of John Griffin
> Sent: Tuesday, March 08, 2016 4:22 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH 0/3] AES GCM, AES CMAC fixes and addition of
> GCM tests for QAT.
>
> This patchset solves an issue in QAT driver, that was giving
> invalid AES GCM results, due to incorrect IV setting.
>
> It adds unit tests to validate AES GCM in QAT.
>
> It also fixes the premature addition of AES CMAC support which was added
> to
> the code in error. AES CMAC will be added in a subsequent release
> when testing completes.
> AES CMAC was not advertised in the qat documentation.
>
> This patchset depends on patches:
> - aesni_gcm: PMD to support AES_GCM crypto operations
> (http://dpdk.org/dev/patchwork/patch/11201/)
>
> John Griffin (3):
> qat: fix AES GCM decryption
> app/test: add AES GCM tests for QAT
> qat: fixes premature addition of AES_CMAC in session
>
> app/test/test_cryptodev.c | 34
> +++++++++++++++++++++++++++++++++-
> doc/guides/cryptodevs/qat.rst | 1 +
> doc/guides/rel_notes/release_16_04.rst | 5 +++++
> drivers/crypto/qat/qat_crypto.c | 24 ++++++++++++++++++++----
> 4 files changed, 59 insertions(+), 5 deletions(-)
>
> --
> 2.1.0
Series-acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Just a small comment: there is a type in the title of last patch,
It should be "premature addition of AES_GMAC in session"
next prev parent reply other threads:[~2016-03-10 17:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 16:22 John Griffin
2016-03-08 16:22 ` [dpdk-dev] [PATCH 1/3] qat: fix AES GCM decryption John Griffin
2016-03-08 16:22 ` [dpdk-dev] [PATCH 2/3] app/test: add AES GCM tests for QAT John Griffin
2016-03-08 16:22 ` [dpdk-dev] [PATCH 3/3] qat: fixes premature addition of AES_CMAC in session creation John Griffin
2016-03-11 0:16 ` Thomas Monjalon
2016-03-11 0:24 ` De Lara Guarch, Pablo
2016-03-11 11:01 ` John Griffin
2016-03-10 17:28 ` De Lara Guarch, Pablo [this message]
2016-03-11 0:33 ` [dpdk-dev] [PATCH 0/3] AES GCM, AES CMAC fixes and addition of GCM tests for QAT Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8973C8C8122@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=dev@dpdk.org \
--cc=john.griffin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).