From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pablo.de.lara.guarch@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 3A4C12935
 for <dev@dpdk.org>; Wed,  6 Apr 2016 13:20:18 +0200 (CEST)
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by fmsmga103.fm.intel.com with ESMTP; 06 Apr 2016 04:20:14 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,447,1455004800"; d="scan'208";a="80077042"
Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23])
 by fmsmga004.fm.intel.com with ESMTP; 06 Apr 2016 04:20:13 -0700
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.13]) by
 IRSMSX109.ger.corp.intel.com ([169.254.13.174]) with mapi id 14.03.0248.002;
 Wed, 6 Apr 2016 12:20:11 +0100
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Olivier Matz <olivier.matz@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "Richardson, Bruce" <bruce.richardson@intel.com>
Thread-Topic: [dpdk-dev] [PATCH v3 0/4] fix creation of duplicate lpm and hash
Thread-Index: AQHRjzH1/0YQf1ZyqkS1KeffAXmkvZ98v6pA///8NwCAABD84A==
Date: Wed, 6 Apr 2016 11:20:10 +0000
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8973C8EAE57@IRSMSX108.ger.corp.intel.com>
References: <1459841759-23296-1-git-send-email-olivier.matz@6wind.com>
 <1459857229-9814-1-git-send-email-olivier.matz@6wind.com>
 <E115CCD9D858EF4F90C690B0DCB4D8973C8EADD1@IRSMSX108.ger.corp.intel.com>
 <5704EFA2.8080901@6wind.com>
In-Reply-To: <5704EFA2.8080901@6wind.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWRkYWUyYzEtNzJjYS00MDE4LTkyZDItNzNkNzJmNGNhOWJhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImpWdlpjMFwvKzlkRFdLNnA4MUQzdldnSjJZTHBhcTVVV3RSSTFralkxTEMwPSJ9
x-ctpclassification: CTP_IC
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v3 0/4] fix creation of duplicate lpm and hash
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Apr 2016 11:20:20 -0000



> -----Original Message-----
> From: Olivier Matz [mailto:olivier.matz@6wind.com]
> Sent: Wednesday, April 06, 2016 12:15 PM
> To: De Lara Guarch, Pablo; dev@dpdk.org
> Cc: Richardson, Bruce
> Subject: Re: [dpdk-dev] [PATCH v3 0/4] fix creation of duplicate lpm and =
hash
>=20
>=20
>=20
> On 04/06/2016 12:32 PM, De Lara Guarch, Pablo wrote:
> >
> > I wonder if you should include something in release notes.
> > We are fixing the API, so I guess we don't need to follow the deprecati=
on
> process, but at least a note in the documentation?
>=20
> Good idea, I'll send a v4 with the deprecation notice.

Well, not sure if this needs a deprecation notice.
I mean, it is an API fix: yes, this is changing what the function returns
in a particular situation (when the hash/lpm already exists) ,
but it was going against the API documentation, so a deprecation notice sho=
uld not be necessary.
(just my opinion, I could be quite wrong here :P).

I was thinking more on adding a note in Resolved issues.

Thanks,
Pablo
>=20
> > Apart from that,
> >
> > Series-acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>=20
> Thank you for the review.
>=20
> Olivier