From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Maciej Czekaj <maciej.czekaj@caviumnetworks.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Mcnamara, John" <john.mcnamara@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 0/3] testpmd: extend commands for better scatter-gather tests
Date: Thu, 28 Apr 2016 13:13:20 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8973C912F9A@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <5721FD7F.8040505@caviumnetworks.com>
> -----Original Message-----
> From: Maciej Czekaj [mailto:maciej.czekaj@caviumnetworks.com]
> Sent: Thursday, April 28, 2016 1:10 PM
> To: De Lara Guarch, Pablo; dev@dpdk.org
> Cc: Mcnamara, John
> Subject: Re: [dpdk-dev] [PATCH v2 0/3] testpmd: extend commands for
> better scatter-gather tests
>
> On Thu, 28 Apr 2016 08:52:59 +0000 De Lara Guarch, Pablo wrote:
> >
> >
> >> -----Original Message-----
> >> From: maciej.czekaj@caviumnetworks.com
> >> [mailto:maciej.czekaj@caviumnetworks.com]
> >> Sent: Friday, April 22, 2016 3:51 PM
> >> To: dev@dpdk.org
> >> Cc: De Lara Guarch, Pablo; Mcnamara, John; Maciej Czekaj
> >> Subject: [PATCH v2 0/3] testpmd: extend commands for better scatter-
> gather
> >> tests
> >>
> >> From: Maciej Czekaj <maciej.czekaj@caviumnetworks.com>
> >>
> >> v2:
> >> - included documentation changes
> >> - added value check for "port config all txqflags" as in --tqxflags
> paramater
> >>
> >> Maciej Czekaj (3):
> >> app/testpmd: add "enable-scatter" parameter
> >> app/testpmd: extend port config with scatter parameter
> >> app/testpmd: support setting up txq_flags value in command line
> >>
> >> app/test-pmd/cmdline.c | 86
> +++++++++++++++++++++++++++--
> >> app/test-pmd/parameters.c | 3 +
> >> doc/guides/testpmd_app_ug/run_app.rst | 4 ++
> >> doc/guides/testpmd_app_ug/testpmd_funcs.rst | 20 +++++++
> >> 4 files changed, 109 insertions(+), 4 deletions(-)
> >>
> >> --
> >> 1.9.1
> >
> > Series-acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> >
> > Just one comment, maybe we should include some extra info in "show port
> info all", like txqflags or scatter mode.
> >
>
> txqflags is displayed in:
> - a forwarding info upon start command
> - show txq info
>
> scatter mode is displayed in:
> - show rxq info
>
> Still I think it is a good point to aggregate it in port info.
>
> I will address it in v3.
Oh, true, good point. Then, probably not necessary, as we would be duplicating information.
next prev parent reply other threads:[~2016-04-28 13:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-22 9:58 [dpdk-dev] [PATCH " maciej.czekaj
2016-04-22 9:58 ` [dpdk-dev] [PATCH 1/3] app/testpmd: add "enable-scatter" parameter maciej.czekaj
2016-04-22 9:58 ` [dpdk-dev] [PATCH 2/3] app/testpmd: extend port config with scatter parameter maciej.czekaj
2016-04-22 9:58 ` [dpdk-dev] [PATCH 3/3] app/testpmd: support setting up txq_flags value in command line maciej.czekaj
2016-04-22 10:19 ` [dpdk-dev] [PATCH 0/3] testpmd: extend commands for better scatter-gather tests Mcnamara, John
2016-04-22 10:38 ` [dpdk-dev] Odp.: " Czekaj, Maciej
2016-04-22 14:51 ` [dpdk-dev] [PATCH v2 " maciej.czekaj
2016-04-28 8:52 ` De Lara Guarch, Pablo
2016-04-28 12:09 ` Maciej Czekaj
2016-04-28 13:13 ` De Lara Guarch, Pablo [this message]
2016-04-28 13:19 ` Maciej Czekaj
2016-06-08 10:38 ` Thomas Monjalon
2016-04-22 14:51 ` [dpdk-dev] [PATCH v2 1/3] app/testpmd: add "enable-scatter" parameter maciej.czekaj
2016-04-22 14:51 ` [dpdk-dev] [PATCH v2 2/3] app/testpmd: extend port config with scatter parameter maciej.czekaj
2016-04-22 14:51 ` [dpdk-dev] [PATCH v2 3/3] app/testpmd: support setting up txq_flags value in command line maciej.czekaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8973C912F9A@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=maciej.czekaj@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).