From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 98C5D39EA for ; Thu, 28 Apr 2016 15:13:22 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP; 28 Apr 2016 06:13:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,546,1455004800"; d="scan'208";a="93609460" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga004.fm.intel.com with ESMTP; 28 Apr 2016 06:13:22 -0700 Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by IRSMSX102.ger.corp.intel.com (163.33.3.155) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 28 Apr 2016 14:13:20 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.238]) by IRSMSX156.ger.corp.intel.com ([169.254.3.32]) with mapi id 14.03.0248.002; Thu, 28 Apr 2016 14:13:20 +0100 From: "De Lara Guarch, Pablo" To: Maciej Czekaj , "dev@dpdk.org" CC: "Mcnamara, John" Thread-Topic: [dpdk-dev] [PATCH v2 0/3] testpmd: extend commands for better scatter-gather tests Thread-Index: AQHRnKaRZ6lTc25XzkiSLDy2c+MuVJ+fGAjQgAArj4CAACIhcA== Date: Thu, 28 Apr 2016 13:13:20 +0000 Message-ID: References: <1461319098-22632-1-git-send-email-maciej.czekaj@caviumnetworks.com> <1461336680-7581-1-git-send-email-maciej.czekaj@caviumnetworks.com> <5721FD7F.8040505@caviumnetworks.com> In-Reply-To: <5721FD7F.8040505@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2RmNDk3YWMtYTM4Mi00NDUyLWJlYzEtYmIwZWU0YjM3MzZhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkE1Y0IzajZlYzJXZHExTmtlTDZTWGZYTXFFSzBjXC9UNExCSUUyVWE5ZlNzPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 0/3] testpmd: extend commands for better scatter-gather tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Apr 2016 13:13:23 -0000 > -----Original Message----- > From: Maciej Czekaj [mailto:maciej.czekaj@caviumnetworks.com] > Sent: Thursday, April 28, 2016 1:10 PM > To: De Lara Guarch, Pablo; dev@dpdk.org > Cc: Mcnamara, John > Subject: Re: [dpdk-dev] [PATCH v2 0/3] testpmd: extend commands for > better scatter-gather tests >=20 > On Thu, 28 Apr 2016 08:52:59 +0000 De Lara Guarch, Pablo wrote: > > > > > >> -----Original Message----- > >> From: maciej.czekaj@caviumnetworks.com > >> [mailto:maciej.czekaj@caviumnetworks.com] > >> Sent: Friday, April 22, 2016 3:51 PM > >> To: dev@dpdk.org > >> Cc: De Lara Guarch, Pablo; Mcnamara, John; Maciej Czekaj > >> Subject: [PATCH v2 0/3] testpmd: extend commands for better scatter- > gather > >> tests > >> > >> From: Maciej Czekaj > >> > >> v2: > >> - included documentation changes > >> - added value check for "port config all txqflags" as in --tqxflags > paramater > >> > >> Maciej Czekaj (3): > >> app/testpmd: add "enable-scatter" parameter > >> app/testpmd: extend port config with scatter parameter > >> app/testpmd: support setting up txq_flags value in command line > >> > >> app/test-pmd/cmdline.c | 86 > +++++++++++++++++++++++++++-- > >> app/test-pmd/parameters.c | 3 + > >> doc/guides/testpmd_app_ug/run_app.rst | 4 ++ > >> doc/guides/testpmd_app_ug/testpmd_funcs.rst | 20 +++++++ > >> 4 files changed, 109 insertions(+), 4 deletions(-) > >> > >> -- > >> 1.9.1 > > > > Series-acked-by: Pablo de Lara > > > > Just one comment, maybe we should include some extra info in "show port > info all", like txqflags or scatter mode. > > >=20 > txqflags is displayed in: > - a forwarding info upon start command > - show txq info >=20 > scatter mode is displayed in: > - show rxq info >=20 > Still I think it is a good point to aggregate it in port info. >=20 > I will address it in v3. Oh, true, good point. Then, probably not necessary, as we would be duplicat= ing information.