From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: add packet data prefetch in macswap loop
Date: Mon, 2 May 2016 17:48:02 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8973C9143DF@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1462190377-26865-1-git-send-email-jerin.jacob@caviumnetworks.com>
Hi Jerin,
> -----Original Message-----
> From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com]
> Sent: Monday, May 02, 2016 1:00 PM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo; Jerin Jacob
> Subject: [dpdk-dev] [PATCH] app/testpmd: add packet data prefetch in
> macswap loop
>
> prefetch the next packet data address in advance in macswap loop
> for performance improvement.
>
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
> app/test-pmd/macswap.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/app/test-pmd/macswap.c b/app/test-pmd/macswap.c
> index 154889d..c10f4b5 100644
> --- a/app/test-pmd/macswap.c
> +++ b/app/test-pmd/macswap.c
> @@ -113,6 +113,9 @@ pkt_burst_mac_swap(struct fwd_stream *fs)
> if (txp->tx_ol_flags & TESTPMD_TX_OFFLOAD_INSERT_QINQ)
> ol_flags |= PKT_TX_QINQ_PKT;
> for (i = 0; i < nb_rx; i++) {
> + if (likely(i < nb_rx - 1))
> + rte_prefetch0(rte_pktmbuf_mtod(pkts_burst[i + 1],
> + void *));
> mb = pkts_burst[i];
> eth_hdr = rte_pktmbuf_mtod(mb, struct ether_hdr *);
>
> --
> 2.1.0
This looks good. Could you also add it in the other forwarding modes (the ones that make changes in the packets)?
Thanks,
Pablo
next prev parent reply other threads:[~2016-05-02 17:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-02 11:59 Jerin Jacob
2016-05-02 17:48 ` De Lara Guarch, Pablo [this message]
2016-05-03 12:46 ` Jerin Jacob
2016-05-03 9:45 ` Bruce Richardson
2016-05-03 9:48 ` De Lara Guarch, Pablo
2016-05-03 10:16 ` Bruce Richardson
2016-05-03 9:50 ` Ivan Boule
2016-05-03 10:20 ` Bruce Richardson
2016-05-10 12:26 ` Ananyev, Konstantin
2016-05-03 14:07 ` [dpdk-dev] [PATCH v2] app/testpmd: add packet data pointer prefetch in the forwarding loop Jerin Jacob
2016-05-03 14:33 ` Thomas Monjalon
2016-06-07 11:19 ` De Lara Guarch, Pablo
2016-06-08 15:57 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8973C9143DF@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).