From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id D4FC2918F for ; Tue, 14 Jun 2016 16:30:33 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP; 14 Jun 2016 07:30:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,470,1459839600"; d="scan'208";a="997385568" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga002.jf.intel.com with ESMTP; 14 Jun 2016 07:30:31 -0700 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by IRSMSX101.ger.corp.intel.com (163.33.3.153) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 14 Jun 2016 15:30:31 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.183]) by irsmsx111.ger.corp.intel.com ([169.254.2.182]) with mapi id 14.03.0248.002; Tue, 14 Jun 2016 15:30:30 +0100 From: "De Lara Guarch, Pablo" To: "Iremonger, Bernard" , "dev@dpdk.org" Thread-Topic: [PATCH v4 4/9] app/testpmd: remove fwd_config_setup from fwd_config_display Thread-Index: AQHRxjhPWsARcLbZq0a9BqBPxjzBpp/o7EBAgAAEnoCAABLNYA== Date: Tue, 14 Jun 2016 14:30:30 +0000 Message-ID: References: <1465744997-15487-1-git-send-email-bernard.iremonger@intel.com> <1465907296-27117-1-git-send-email-bernard.iremonger@intel.com> <1465907296-27117-5-git-send-email-bernard.iremonger@intel.com> <8CEF83825BEC744B83065625E567D7C21A0394D5@IRSMSX108.ger.corp.intel.com> In-Reply-To: <8CEF83825BEC744B83065625E567D7C21A0394D5@IRSMSX108.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjlhNDg1MWQtNDYyNi00YzI2LTkyN2UtMDBlYWNhNjQ1ZmY0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjZuOXI5YlZabVRlMTBRdUZ1QmhHMXJTWWJFVWN1VEZGSE9NTlFsK1FCbnM9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 4/9] app/testpmd: remove fwd_config_setup from fwd_config_display X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jun 2016 14:30:34 -0000 > -----Original Message----- > From: Iremonger, Bernard > Sent: Tuesday, June 14, 2016 3:14 PM > To: De Lara Guarch, Pablo; dev@dpdk.org > Subject: RE: [PATCH v4 4/9] app/testpmd: remove fwd_config_setup from > fwd_config_display >=20 > Hi Pablo, >=20 > >=20 > > > Subject: [PATCH v4 4/9] app/testpmd: remove fwd_config_setup from > > > fwd_config_display > > > > > > Add call to fwd_config_setup to init_config. > > > Remove fwd_config_setup from fwd_config_display. > > > Add call to fwd_config_setup for corelist, coremask and nbcore setup. > > > Add call to fwd_config_setup for portlist, portmask and nbport setup. > > > Add call to fwd_config_setup for rxq, txq, rxd and txd setup. > > > > > > Signed-off-by: Bernard Iremonger > > > > Apologies for misleading here, but I think we should drop this patch fo= r the > > moment. > > It is conflicting with another patch and it is not really necessary for= your > > changes (am I right here?), so I would say best thing to do is to drop = it and > > discuss if we want this change separately. >=20 > This patch is needed for the patchset and should not be dropped. >=20 > Is it conflicting with patch the following patch? >=20 > http://dpdk.org/dev/patchwork/patch/13132/ >=20 > This patch is renaming fwd_config_display to fwd_config_setup_display. > It clarifies what the function is doing, but does not address the issue o= f > separating the setup from the display. >=20 > Separating the setup from the display is resolved in my patch. Right, I thought this was only refactoring. Sorry about that! Anyway, since fwd_config_display() is going to call only pkt_fwd_config_dis= play() now, it makes sense to move the code from that function to fwd_config_display(). You can send a separate patch for that, as it is only refactoring. Thanks, Pablo >=20 > Regards, >=20 > Bernard. >=20 >=20