Re: [dpdk-dev] [PATCH v2] cryptodev: uninline parameter parsing

["De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>]

Hi Thomas,

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Saturday, June 25, 2016 2:14 PM
> To: Doherty, Declan; De Lara Guarch, Pablo
> Cc: dev@dpdk.org
> Subject: [PATCH v2] cryptodev: uninline parameter parsing
> 
> There is no need to have this parsing inlined in the header.
> It brings kvargs dependency to every crypto drivers.
> The functions are moved into rte_cryptodev.c.
> 
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> ---
> v2:
> - remove kvargs dep in null PMD
> - add function in .map file
> ---
>  drivers/crypto/null/Makefile                   |  1 -
>  lib/librte_cryptodev/rte_cryptodev.c           | 91 ++++++++++++++++++++++++
>  lib/librte_cryptodev/rte_cryptodev.h           | 95 ++------------------------
>  lib/librte_cryptodev/rte_cryptodev_version.map |  7 ++
>  4 files changed, 102 insertions(+), 92 deletions(-)
> 
> diff --git a/drivers/crypto/null/Makefile b/drivers/crypto/null/Makefile
> index 573894f..35db8b1 100644
> --- a/drivers/crypto/null/Makefile
> +++ b/drivers/crypto/null/Makefile
> @@ -56,6 +56,5 @@ DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_NULL_CRYPTO)
> += lib/librte_eal
>  DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_NULL_CRYPTO) += lib/librte_mbuf
>  DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_NULL_CRYPTO) +=
> lib/librte_cryptodev
>  DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_NULL_CRYPTO) += lib/librte_ring
> -DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_NULL_CRYPTO) += lib/librte_kvargs
> 
>  include $(RTE_SDK)/mk/rte.lib.mk

[...]

>  /**
>   * Create a virtual crypto device
> diff --git a/lib/librte_cryptodev/rte_cryptodev_version.map
> b/lib/librte_cryptodev/rte_cryptodev_version.map
> index 41004e1..a08fd20 100644
> --- a/lib/librte_cryptodev/rte_cryptodev_version.map
> +++ b/lib/librte_cryptodev/rte_cryptodev_version.map
> @@ -32,3 +32,10 @@ DPDK_16.04 {
> 
>  	local: *;
>  };
> +
> +DPDK_16.07 {
> +	global:
> +
> +	rte_cryptodev_parse_vdev_init_params;

I think this function does not need to be public.
This function is only called in the PMDs, and the only public function
to initialize a crypto device is rte_eal_vdev_init.

> +
> +} DPDK_16.04;
> --
> 2.7.0

Also, could you remove the includes of rte_vargs.h in the PMDs,
as it is not needed (I think it was not necessary before either).