From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] kni: support RHEL 7.3
Date: Thu, 15 Sep 2016 22:52:19 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8973C9E7B96@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <e2da03d2-389b-5139-d66b-fb23392ee445@intel.com>
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Thursday, September 15, 2016 3:13 AM
> To: De Lara Guarch, Pablo; dev@dpdk.org
> Subject: Re: [PATCH] kni: support RHEL 7.3
>
> On 9/14/2016 7:25 PM, Pablo de Lara wrote:
> > Add support for RHEL 7.3, which uses kernel 3.10,
> > but backported features from newer kernels.
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > ---
> > lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h | 7 ++++---
> > 1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h
> b/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h
> > index bdd0806..1e20a9e 100644
> > --- a/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h
> > +++ b/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h
> > @@ -3891,7 +3891,7 @@ skb_set_hash(struct sk_buff *skb, __u32 hash,
> __always_unused int type)
> > #if (( LINUX_VERSION_CODE >= KERNEL_VERSION(3,19,0) ) \
> > || ( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,2) ))
> > #define HAVE_NDO_DFLT_BRIDGE_ADD_MASK
> > -#if (!( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,2) ))
> > +#if (!( RHEL_RELEASE_CODE == RHEL_RELEASE_VERSION(7,2) ))
>
> What about following to simplify the logic:
> +#if ( RHEL_RELEASE_CODE != RHEL_RELEASE_VERSION(7,2) )
>
Good point. Will send a v2 with that :)
Thanks,
Pablo
> Thanks,
> ferruh
next prev parent reply other threads:[~2016-09-15 22:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 18:25 Pablo de Lara
2016-09-15 10:12 ` Ferruh Yigit
2016-09-15 22:52 ` De Lara Guarch, Pablo [this message]
2016-09-16 21:01 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
2016-09-19 9:01 ` Ferruh Yigit
2016-09-21 16:11 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8973C9E7B96@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).