From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 034658D9F for ; Sat, 17 Sep 2016 02:59:44 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP; 16 Sep 2016 17:59:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,347,1470726000"; d="scan'208";a="10141891" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by orsmga005.jf.intel.com with ESMTP; 16 Sep 2016 17:59:43 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.167]) by IRSMSX151.ger.corp.intel.com ([169.254.4.67]) with mapi id 14.03.0248.002; Sat, 17 Sep 2016 01:59:42 +0100 From: "De Lara Guarch, Pablo" To: "Jain, Deepak K" , "dev@dpdk.org" Thread-Topic: [PATCH v3 1/3] app/test: cleanup of test code for kasumi Thread-Index: AQHSDzh9hKGIbQKhfkmiHNhMgflze6B8q4MQ Date: Sat, 17 Sep 2016 00:59:41 +0000 Message-ID: References: <1472131419-89617-1-git-send-email-deepak.k.jain@intel.com> <1473933815-185834-1-git-send-email-deepak.k.jain@intel.com> <1473933815-185834-2-git-send-email-deepak.k.jain@intel.com> In-Reply-To: <1473933815-185834-2-git-send-email-deepak.k.jain@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTcyODgzNGMtNjFkMi00NTk4LWFiNTctYTU3NzAwOTI0ZmU1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlRFUVhqSjhDK01YVzBlejZIK2VjSFlQNDdYRm4zZ0t4RXo2aEhaQUJTQUE9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 1/3] app/test: cleanup of test code for kasumi X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Sep 2016 00:59:45 -0000 Hi Deepak, > -----Original Message----- > From: Jain, Deepak K > Sent: Thursday, September 15, 2016 3:04 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo; Jain, Deepak K > Subject: [PATCH v3 1/3] app/test: cleanup of test code for kasumi >=20 > Cleanup for easier kasumi enabling. > Changed name of funcitons for clear understanding. Typo in "funcitons". Could you split this patch in two? One for the rename the functions and ano= ther one for the rest. Actually, are you doing something else apart from cleanup/reordering? >=20 > Signed-off-by: Deepak Kumar Jain > --- > app/test/test_cryptodev.c | 117 ++++++++++++++++++++++------------------= ------ > 1 file changed, 55 insertions(+), 62 deletions(-) >=20 > diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c > index 67ca912..89d627f 100644 > --- a/app/test/test_cryptodev.c > +++ b/app/test/test_cryptodev.c > @@ -1448,74 +1448,67 @@ > create_snow3g_kasumi_cipher_hash_operation(const uint8_t *auth_tag, ... > TEST_ASSERT_NOT_NULL(sym_op->auth.aad.data, > "no room to prepend aad"); > sym_op->auth.aad.phys_addr =3D rte_pktmbuf_mtophys( > ut_params->ibuf); > sym_op->auth.aad.length =3D aad_len; > - > - memset(sym_op->auth.aad.data, 0, aad_buffer_len); > + memset(sym_op->auth.aad.data, 0, aad_buffer_len); No need to include extra tab. > rte_memcpy(sym_op->auth.aad.data, aad, aad_len); > + TEST_HEXDUMP(stdout, "aad:", > + sym_op->auth.aad.data, aad_len); No need to include extra tab. >=20 > - TEST_HEXDUMP(stdout, "aad:", > - sym_op->auth.aad.data, aad_len); > - > - /* digest */ > - sym_op->auth.digest.data =3D (uint8_t *)rte_pktmbuf_append( > - ut_params->ibuf, auth_tag_len); ... > @@ -2714,12 +2707,12 @@ test_snow3g_authenticated_encryption(const > struct snow3g_test_data *tdata) > ut_params->obuf =3D ut_params->op->sym->m_src; > if (ut_params->obuf) > ciphertext =3D rte_pktmbuf_mtod(ut_params->obuf, uint8_t *) > - + tdata->iv.len; > + + tdata->iv.len + tdata->aad.len; > else > ciphertext =3D plaintext; >=20 > TEST_HEXDUMP(stdout, "ciphertext:", ciphertext, plaintext_len); > - > + TEST_HEXDUMP(stdout, "OUTPUT BUFFER:", ut_params->obuf, 512); Magic number? What are you showing here? > /* Validate obuf */ > TEST_ASSERT_BUFFERS_ARE_EQUAL_BIT( > ciphertext, > @@ -2728,7 +2721,7 @@ test_snow3g_authenticated_encryption(const > struct snow3g_test_data *tdata) > "Snow3G Ciphertext data not as expected"); >=20