From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 0/2] examples/l2fwd: Add option to enable/disable MAC addresses tweaking
Date: Fri, 23 Sep 2016 17:11:09 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8973C9FCEE8@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <90027557-a2cb-f73c-5a7e-a577b8c12215@redhat.com>
> -----Original Message-----
> From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]
> Sent: Friday, September 23, 2016 6:52 AM
> To: De Lara Guarch, Pablo; Richardson, Bruce
> Cc: dev@dpdk.org
> Subject: Re: [PATCH 0/2] examples/l2fwd: Add option to enable/disable MAC
> addresses tweaking
>
>
>
> On 09/21/2016 11:53 PM, De Lara Guarch, Pablo wrote:
> >
> >
> >> -----Original Message-----
> >> From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]
> >> Sent: Tuesday, July 26, 2016 8:56 AM
> >> To: Richardson, Bruce; De Lara Guarch, Pablo
> >> Cc: dev@dpdk.org; Maxime Coquelin
> >> Subject: [PATCH 0/2] examples/l2fwd: Add option to enable/disable MAC
> >> addresses tweaking
> >>
> >> This series adds a new option to enable/disable MAC addresses tweaking
> in
> >> l2fwd example.
> >>
> >> Doing that, we can enable basic VM 2 VM communication easily, without
> >> external projects dependencies, nor real NIC (as with vhost example).
> >>
> >> Example of cli with vhost-user:
> >>
> >> #l2fwd -c f --socket-mem=1024 \
> >> --vdev 'eth_vhost0,iface=/tmp/vhost-user1,queues=1' \
> >> --vdev 'eth_vhost1,iface=/tmp/vhost-user2,queues=1' \
> >> -- -p3 --no-mac-tweaking
> >>
> >> By default, MAC addresses tweaking remains enabled, but maybe we
> could
> >> consider having it disabled by default to be consistent with l2fwd-cat
> >> for example.
> >>
> >> Maxime Coquelin (2):
> >> examples/l2fwd: Add new option to enable/disable MAC addresses
> >> tweaking
> >> doc: l2fwd: document new --[no-]mac-tweaking option
> >>
> >> doc/guides/sample_app_ug/img/l2_fwd_vm2vm.svg | 311
> >> +++++++++++++++++++++
> >> .../sample_app_ug/l2_forward_real_virtual.rst | 24 +-
> >> examples/l2fwd/main.c | 39 ++-
> >> 3 files changed, 358 insertions(+), 16 deletions(-)
> >> create mode 100644 doc/guides/sample_app_ug/img/l2_fwd_vm2vm.svg
> >>
> >> --
> >> 2.7.4
> >
> > Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> >
> Thanks Pablo,
>
> Just sent the v2, but didn't applied your Ack since I did some changes,
> even though trivial ones.
This looks good to me, as well.
Pablo
>
> Regards,
> Maxime
prev parent reply other threads:[~2016-09-23 17:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-26 15:56 Maxime Coquelin
2016-07-26 15:56 ` [dpdk-dev] [PATCH 1/2] examples/l2fwd: Add new " Maxime Coquelin
2016-08-30 15:42 ` Mcnamara, John
2016-07-26 15:56 ` [dpdk-dev] [PATCH 2/2] doc: l2fwd: document new --[no-]mac-tweaking option Maxime Coquelin
2016-08-30 15:42 ` [dpdk-dev] [PATCH 0/2] examples/l2fwd: Add option to enable/disable MAC addresses tweaking Mcnamara, John
2016-09-23 13:54 ` Maxime Coquelin
2016-09-21 21:53 ` De Lara Guarch, Pablo
2016-09-23 13:52 ` Maxime Coquelin
2016-09-23 17:11 ` De Lara Guarch, Pablo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8973C9FCEE8@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).