Re: [dpdk-dev] [PATCH v2] app/test: add AES GCM performance test to cryptodev

["De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>]

Hi Arek,

> -----Original Message-----
> From: Jain, Deepak K
> Sent: Monday, September 26, 2016 12:43 PM
> To: Kusztal, ArkadiuszX; dev@dpdk.org
> Cc: Trahe, Fiona; De Lara Guarch, Pablo; Griffin, John
> Subject: RE: [PATCH v2] app/test: add AES GCM performance test to
> cryptodev
> 
> 
> 
> > -----Original Message-----
> > From: Kusztal, ArkadiuszX
> > Sent: Friday, September 23, 2016 11:30 AM
> > To: dev@dpdk.org
> > Cc: Trahe, Fiona <fiona.trahe@intel.com>; Jain, Deepak K
> > <deepak.k.jain@intel.com>; De Lara Guarch, Pablo
> > <pablo.de.lara.guarch@intel.com>; Griffin, John <john.griffin@intel.com>;
> > Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
> > Subject: [PATCH v2] app/test: add AES GCM performance test to cryptodev
> >
> > This patch adds AES Galois Counter Mode performance test case for
> > cryptodev QAT tests. Test is performed with different buffer sizes, burst size
> > of 32 and 128b key. Test vectors are placed in
> > app/test/test_cryptodev_perf_vectors.h file.
> >
> > This patch depends on the following patches/patchsets:
> >
> > "app/test: fix linkage scope of gmac plaintext array"
> > (http://dpdk.org/dev/patchwork/patch/16023/)
> >
> > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> > ---
> > v2:
> >   * Fixed 32b build problem in test_cryptodev_perf.c
> > ---
> >  app/test/test_cryptodev_gcm_test_vectors.h | 636
> > +++++++++++++++++++++++++++++
> >  app/test/test_cryptodev_perf.c             | 431 ++++++++++++++++++-
> >  2 files changed, 1064 insertions(+), 3 deletions(-)
> >
> > --
> > 2.1.0
> Acked-by: Deepak Kumar Jain <deepak.k.jain@intel.com>

Could you also add another test for the aesni gcm sw pmd that uses this new test?
All you need to do is add a new test suite (aes_gcm_testsuite) that runs the test case
"test_perf_AES_GCM_perf_test" (btw, this looks redundant, why don't call it test_perf_aes_gcm?)
and then add the command to call the test suite.

Another thing, next time, could you move the patch dependency comment
to the area after the three dashes in the commit, so it is not part of the commit message?

Thanks,
Pablo