From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 140A22C0A for ; Tue, 27 Sep 2016 01:29:11 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP; 26 Sep 2016 16:29:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,401,1470726000"; d="scan'208";a="884064659" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by orsmga003.jf.intel.com with ESMTP; 26 Sep 2016 16:29:10 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.164]) by IRSMSX151.ger.corp.intel.com ([169.254.4.226]) with mapi id 14.03.0248.002; Tue, 27 Sep 2016 00:29:09 +0100 From: "De Lara Guarch, Pablo" To: "Jain, Deepak K" , "Kusztal, ArkadiuszX" , "dev@dpdk.org" CC: "Trahe, Fiona" , "Griffin, John" Thread-Topic: [PATCH v2] app/test: add AES GCM performance test to cryptodev Thread-Index: AQHSFYV4kQKZQMQzbUiCwj2594qdQKCMILUAgABAiyA= Date: Mon, 26 Sep 2016 23:29:08 +0000 Message-ID: References: <1474626587-18214-1-git-send-email-arkadiuszx.kusztal@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjRlMzRhOWItOThmZi00YTc4LTk4YmUtYzFiMDk4MjkyNjEwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IktVcXMzNlwvWCtZZW1LY3R4ekdQQTBNUVJJOEFWdjhoNlZMOW9hSjhCUVRNPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] app/test: add AES GCM performance test to cryptodev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Sep 2016 23:29:12 -0000 Hi Arek, > -----Original Message----- > From: Jain, Deepak K > Sent: Monday, September 26, 2016 12:43 PM > To: Kusztal, ArkadiuszX; dev@dpdk.org > Cc: Trahe, Fiona; De Lara Guarch, Pablo; Griffin, John > Subject: RE: [PATCH v2] app/test: add AES GCM performance test to > cryptodev >=20 >=20 >=20 > > -----Original Message----- > > From: Kusztal, ArkadiuszX > > Sent: Friday, September 23, 2016 11:30 AM > > To: dev@dpdk.org > > Cc: Trahe, Fiona ; Jain, Deepak K > > ; De Lara Guarch, Pablo > > ; Griffin, John ; > > Kusztal, ArkadiuszX > > Subject: [PATCH v2] app/test: add AES GCM performance test to cryptodev > > > > This patch adds AES Galois Counter Mode performance test case for > > cryptodev QAT tests. Test is performed with different buffer sizes, bur= st size > > of 32 and 128b key. Test vectors are placed in > > app/test/test_cryptodev_perf_vectors.h file. > > > > This patch depends on the following patches/patchsets: > > > > "app/test: fix linkage scope of gmac plaintext array" > > (http://dpdk.org/dev/patchwork/patch/16023/) > > > > Signed-off-by: Arek Kusztal > > --- > > v2: > > * Fixed 32b build problem in test_cryptodev_perf.c > > --- > > app/test/test_cryptodev_gcm_test_vectors.h | 636 > > +++++++++++++++++++++++++++++ > > app/test/test_cryptodev_perf.c | 431 ++++++++++++++++++- > > 2 files changed, 1064 insertions(+), 3 deletions(-) > > > > -- > > 2.1.0 > Acked-by: Deepak Kumar Jain Could you also add another test for the aesni gcm sw pmd that uses this new= test? All you need to do is add a new test suite (aes_gcm_testsuite) that runs th= e test case "test_perf_AES_GCM_perf_test" (btw, this looks redundant, why don't call it= test_perf_aes_gcm?) and then add the command to call the test suite. Another thing, next time, could you move the patch dependency comment to the area after the three dashes in the commit, so it is not part of the = commit message? Thanks, Pablo