From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 57C1C38EB for ; Thu, 29 Sep 2016 16:29:21 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP; 29 Sep 2016 07:29:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,415,1470726000"; d="scan'208";a="767208216" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by FMSMGA003.fm.intel.com with ESMTP; 29 Sep 2016 07:29:19 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.164]) by IRSMSX104.ger.corp.intel.com ([163.33.3.159]) with mapi id 14.03.0248.002; Thu, 29 Sep 2016 15:29:18 +0100 From: "De Lara Guarch, Pablo" To: Thomas Monjalon , "Trahe, Fiona" CC: "dev@dpdk.org" , "akhil.goyal@nxp.com" Thread-Topic: [dpdk-dev] [PATCH] app/test: Remove hard coding for nb_queue_pairs in test_cryptodev Thread-Index: AQHSF+Xv7pl0hzz7qU2JAu5L5KhFMKCMJ6OQgAROzQCAAAONAIAAEYDQ Date: Thu, 29 Sep 2016 14:29:17 +0000 Message-ID: References: <20160926163300.22990-1-akhil.goyal@nxp.com> <348A99DA5F5B7549AA880327E580B435890E9364@IRSMSX101.ger.corp.intel.com> <2002488.2H5o8Bgc8G@xps13> In-Reply-To: <2002488.2H5o8Bgc8G@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmRmOTgzYjItM2YwMi00YjViLWFmOGQtNTFiN2JhMTkzNDZhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InpCczNhOExOWHN6NnhnQWF0SWVDRDJuMUVRM3VTa3RnUmhkeUcyc2F4OWc9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/test: Remove hard coding for nb_queue_pairs in test_cryptodev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Sep 2016 14:29:21 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Thursday, September 29, 2016 7:25 AM > To: Trahe, Fiona > Cc: dev@dpdk.org; De Lara Guarch, Pablo; akhil.goyal@nxp.com > Subject: Re: [dpdk-dev] [PATCH] app/test: Remove hard coding for > nb_queue_pairs in test_cryptodev >=20 > 2016-09-29 14:12, Trahe, Fiona: > > > > From: Akhil Goyal > > > > > > > > nb_queue_pairs should not be hard coded with device specific number= . > > > > It should be retrieved from the device infos. > > > > Also in ut_setup, ts_params->conf.nb_queue_pairs is already set in > > > > testsuite_setup and we are not modifying it. > > > > > > > > Signed-off-by: Akhil Goyal > > > > > > Acked-by: Pablo de Lara > > > > The above code is correct, however it exposes a bug in QAT PMD unit tes= ts. > > And some cleanup needed for unnecessary qp setup code. > > That cleanup then exposed a bug in aesni_mb PMD which prevents re- > creating queue pairs of a different size. > > > > I have a fix and cleanup patch ready. > > Just not sure how best to push it? > > The original patch also needs rebasing, doesn't apply cleanly to the la= test > dpdk-next-crypto > > > > Pablo should I push all as a reply to the first patch - waiting first f= or that to > be rebased? > > Or > > It would save Akhil a rebase and be simpler if I can include the origin= al > change in my patch and push all as a v2 superceding the original patch? = Is > this possible? > > Or > > should I Nack the original patch and push all instead? >=20 > My preference goes to a v2. Agree, send a v2, including your name and Akhil's.=20 Thanks, Pablo