From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd-power: fix inappropiate Rx queue count method
Date: Fri, 4 Nov 2016 12:23:17 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8973CA22A16@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1478217850-77177-1-git-send-email-pablo.de.lara.guarch@intel.com>
> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Friday, November 04, 2016 12:04 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo
> Subject: [PATCH] examples/l3fwd-power: fix inappropiate Rx queue count
> method
>
> Since commit b4f3c136a179 ("net/ixgbe: support checksum flags in SSE vector
> Rx"),
> when HW IP Checksum is enabled, the RX vector function is available to use.
> In case of L3fwd-power, since it is enabled, the RX vector function
> was not used, but after this commit, it is. This has affected the way
> to calculate how full an RX queue is, using rte_eth_rx_descriptor done
> function, making the frequency to be at maximum, even when the frequency
> is very low.
>
> This commit reverts the way to know how full a queue is to the
> previous way, using rte_eth_rx_queue_count(), making it work for both
> vector and scalar RX functions.
>
> Fixes: b451aa39db31 ("examples/l3fwd-power: use DD bit rather than RX
> queue count")
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
NACK, after doing some more tests with other drivers, this solution does not work.
Will send a documentation patch instead.
prev parent reply other threads:[~2016-11-04 12:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-04 0:04 Pablo de Lara
2016-11-04 12:23 ` De Lara Guarch, Pablo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8973CA22A16@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).