From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 78E1B5587 for ; Wed, 30 Nov 2016 16:16:25 +0100 (CET) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP; 30 Nov 2016 07:16:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,574,1473145200"; d="scan'208";a="37379576" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by fmsmga005.fm.intel.com with ESMTP; 30 Nov 2016 07:16:21 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.145]) by IRSMSX101.ger.corp.intel.com ([163.33.3.153]) with mapi id 14.03.0248.002; Wed, 30 Nov 2016 15:16:20 +0000 From: "De Lara Guarch, Pablo" To: "Griffin, John" , "Trahe, Fiona" , "dev@dpdk.org" CC: "Jastrzebski, MichalX K" , "Kusztal, ArkadiuszX" Thread-Topic: [PATCH] crypto: remove unused digest-appended feature Thread-Index: AQHSQPi5GFZUkDrS20+Tf90tDFgOqKDdb2uAgAGeQ4CAEqm+AA== Date: Wed, 30 Nov 2016 15:16:19 +0000 Message-ID: References: <1479403997-15437-1-git-send-email-fiona.trahe@intel.com> <1479403997-15437-2-git-send-email-fiona.trahe@intel.com> <582F455F.3030505@intel.com> In-Reply-To: <582F455F.3030505@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjkxYzc2OTgtMTAwNS00MmNlLWIwYTUtOGQzZmI0MWEzZGFkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImtBQjJhamtrU0txWTA4czNhQVRNYWdvTzJnWE5TNkowSjVWeGlyXC81d1hBPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] crypto: remove unused digest-appended feature X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Nov 2016 15:16:25 -0000 > -----Original Message----- > From: Griffin, John > Sent: Friday, November 18, 2016 6:16 PM > To: Trahe, Fiona; dev@dpdk.org > Cc: De Lara Guarch, Pablo; Jastrzebski, MichalX K; Kusztal, ArkadiuszX > Subject: Re: [PATCH] crypto: remove unused digest-appended feature >=20 > On 17/11/16 17:33, Fiona Trahe wrote: > > The cryptodev API had specified that if the digest address field was > > left empty on an authentication operation, then the PMD would assume > > the digest was appended to the source or destination data. > > This case was not handled at all by most PMDs and incorrectly handled > > by the QAT PMD. > > As no bugs were raised, it is assumed to be not needed, so this patch > > removes it, rather than add handling for the case on all PMDs. > > The digest can still be appended to the data, but its > > address must now be provided in the op. > > > > Signed-off-by: Fiona Trahe > > --- > > drivers/crypto/qat/qat_adf/qat_algs_build_desc.c | 2 ++ > > drivers/crypto/qat/qat_crypto.c | 18 +--------------= --- > > lib/librte_cryptodev/rte_crypto_sym.h | 10 +--------- > > 3 files changed, 4 insertions(+), 26 deletions(-) > > >=20 > Acked-by: John Griffin Applied to dpdk-next-crypto. Thanks, Pablo