From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Mrozowicz, SlawomirX" <slawomirx.mrozowicz@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Mrozowicz, SlawomirX" <slawomirx.mrozowicz@intel.com>,
"Doherty, Declan" <declan.doherty@intel.com>,
"Azarewicz, PiotrX T" <piotrx.t.azarewicz@intel.com>,
"Kerlin, Marcin" <marcin.kerlin@intel.com>,
"Kobylinski, MichalX" <michalx.kobylinski@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 3/3] app/crypto-perf: introduce new performance test application
Date: Mon, 9 Jan 2017 14:51:25 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D897476C08E2@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1483635001-15473-4-git-send-email-slawomirx.mrozowicz@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Slawomir
> Mrozowicz
> Sent: Thursday, January 05, 2017 4:50 PM
> To: dev@dpdk.org
> Cc: Mrozowicz, SlawomirX; Doherty, Declan; Azarewicz, PiotrX T; Kerlin,
> Marcin; Kobylinski, MichalX
> Subject: [dpdk-dev] [PATCH v2 3/3] app/crypto-perf: introduce new
> performance test application
>
> This patchset introduce new application which allows measuring
> performance parameters of PMDs available in crypto tree. The goal of
> this application is to replace existing performance tests in app/test.
> Parameters available are: throughput (--ptest throughput) and latency
> (--ptest latency). User can use multiply cores to run tests on but only
> one type of crypto PMD can be measured during single application
> execution. Cipher parameters, type of device, type of operation and
> chain mode have to be specified in the command line as application
> parameters. These parameters are checked using device capabilities
> structure.
> Couple of new library functions in librte_cryptodev are introduced for
> application use.
> To build the application a CONFIG_RTE_APP_CRYPTO_PERF flag has to be
> set
> (it is set by default).
> Example of usage: -c 0xc0 --vdev crypto_aesni_mb_pmd -w 0000:00:00.0 --
> --ptest throughput --devtype crypto_aesni_mb --optype cipher-then-auth
> --cipher-algo aes-cbc --cipher-op encrypt --cipher-key-sz 16 --auth-algo
> sha1-hmac --auth-op generate --auth-key-sz 64 --auth-digest-sz 12
> --total-ops 10000000 --burst-sz 32 --buffer-sz 64
>
> Signed-off-by: Declan Doherty <declan.doherty@intel.com>
> Signed-off-by: Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>
> Signed-off-by: Piotr Azarewicz <piotrx.t.azarewicz@intel.com>
> Signed-off-by: Marcin Kerlin <marcinx.kerlin@intel.com>
> Signed-off-by: Michal Kobylinski <michalx.kobylinski@intel.com>
> ---
> MAINTAINERS | 4 +
> app/Makefile | 1 +
> app/crypto-perf/Makefile | 51 ++
> app/crypto-perf/cperf.h | 58 ++
> app/crypto-perf/cperf_ops.c | 474 +++++++++++++++
> app/crypto-perf/cperf_ops.h | 66 +++
> app/crypto-perf/cperf_options.h | 104 ++++
> app/crypto-perf/cperf_options_parsing.c | 875
> ++++++++++++++++++++++++++++
> app/crypto-perf/cperf_test_latency.c | 685
> ++++++++++++++++++++++
> app/crypto-perf/cperf_test_latency.h | 57 ++
> app/crypto-perf/cperf_test_throughput.c | 651
> +++++++++++++++++++++
> app/crypto-perf/cperf_test_throughput.h | 58 ++
> app/crypto-perf/cperf_test_vector_parsing.c | 500 ++++++++++++++++
> app/crypto-perf/cperf_test_vector_parsing.h | 73 +++
> app/crypto-perf/cperf_test_vectors.c | 476 +++++++++++++++
> app/crypto-perf/cperf_test_vectors.h | 98 ++++
> app/crypto-perf/cperf_verify_parser.c | 314 ++++++++++
> app/crypto-perf/data/aes_cbc_128_sha.data | 503 ++++++++++++++++
> app/crypto-perf/data/aes_cbc_192_sha.data | 504 ++++++++++++++++
> app/crypto-perf/data/aes_cbc_256_sha.data | 504 ++++++++++++++++
> app/crypto-perf/main.c | 411 +++++++++++++
> config/common_base | 6 +
> doc/guides/rel_notes/release_17_02.rst | 5 +
> doc/guides/tools/cryptoperf.rst | 397 +++++++++++++
> doc/guides/tools/index.rst | 1 +
> 25 files changed, 6876 insertions(+)
...
> diff --git a/app/crypto-perf/cperf_options_parsing.c b/app/crypto-
> perf/cperf_options_parsing.c
...
> +int
> +cperf_options_check(struct cperf_options *options)
> +{
> + if (options->segments_nb > options->buffer_sz) {
> + RTE_LOG(ERR, USER1,
> + "Segments number greater than buffer
> size.\n");
> + return -EINVAL;
> + }
...
> + } else if (options->op_type == CPERF_AEAD) {
> + if (!(options->cipher_op ==
> RTE_CRYPTO_CIPHER_OP_ENCRYPT &&
> + options->auth_op ==
> + RTE_CRYPTO_AUTH_OP_GENERATE) ||
This logic is incorrect. This OR should be an AND.
> + !(options->cipher_op ==
> + RTE_CRYPTO_CIPHER_OP_DECRYPT &&
> + options->auth_op ==
> + RTE_CRYPTO_AUTH_OP_VERIFY)) {
> + RTE_LOG(ERR, USER1, "Use together options:
> encrypt and"
> + " generate or decrypt and verify.\n");
> + return -EINVAL;
> + }
> + }
> +
> + return 0;
> +}
next prev parent reply other threads:[~2017-01-09 14:51 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 15:15 [dpdk-dev] [PATCH 0/2] Introduce " Michal Jastrzebski
2016-12-02 15:15 ` [dpdk-dev] [PATCH 1/2] lib/librte_cryptodev: functions for " Michal Jastrzebski
2016-12-02 15:15 ` [dpdk-dev] [PATCH 2/2] app/crypto-perf: Introduce " Michal Jastrzebski
2017-01-05 16:49 ` [dpdk-dev] [PATCH v2 0/4] " Slawomir Mrozowicz
2017-01-05 16:49 ` [dpdk-dev] [PATCH v2 1/3] eal: add quiet mode to suppress log output to stdout Slawomir Mrozowicz
2017-01-05 15:40 ` Thomas Monjalon
2017-01-10 10:41 ` Declan Doherty
2017-01-05 16:50 ` [dpdk-dev] [PATCH v2 2/3] lib/librte_cryptodev: functions for new performance test application Slawomir Mrozowicz
2017-01-06 12:21 ` De Lara Guarch, Pablo
2017-01-09 9:11 ` Mrozowicz, SlawomirX
2017-01-05 16:50 ` [dpdk-dev] [PATCH v2 3/3] app/crypto-perf: introduce " Slawomir Mrozowicz
2017-01-09 14:51 ` De Lara Guarch, Pablo [this message]
2017-01-10 7:28 ` Mrozowicz, SlawomirX
2017-01-09 15:24 ` Thomas Monjalon
2017-01-10 8:52 ` Mrozowicz, SlawomirX
2017-01-11 16:07 ` [dpdk-dev] [PATCH v3 0/2] Introduce " Slawomir Mrozowicz
2017-01-11 16:07 ` [dpdk-dev] [PATCH v3 1/2] cryptodev: add functions to retrieve device info Slawomir Mrozowicz
2017-01-11 15:21 ` Trahe, Fiona
2017-01-11 16:07 ` [dpdk-dev] [PATCH v3 2/2] app/crypto-perf: introduce new performance test application Slawomir Mrozowicz
2017-01-25 16:27 ` [dpdk-dev] [PATCH v4 0/4] Introduce " Slawomir Mrozowicz
2017-01-25 15:59 ` De Lara Guarch, Pablo
2017-01-26 9:43 ` De Lara Guarch, Pablo
2017-01-25 16:27 ` [dpdk-dev] [PATCH v4 1/4] cryptodev: add functions to retrieve device info Slawomir Mrozowicz
2017-01-25 16:27 ` [dpdk-dev] [PATCH v4 2/4] app/crypto-perf: introduce new performance test application Slawomir Mrozowicz
2017-01-25 16:27 ` [dpdk-dev] [PATCH v4 3/4] app/crypto-perf: add test vectors files Slawomir Mrozowicz
2017-01-25 16:27 ` [dpdk-dev] [PATCH v4 4/4] doc: describe new performance test application Slawomir Mrozowicz
2017-01-26 15:21 ` Ferruh Yigit
2017-01-26 15:23 ` Richardson, Bruce
2017-01-26 17:53 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D897476C08E2@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=marcin.kerlin@intel.com \
--cc=michalx.kobylinski@intel.com \
--cc=piotrx.t.azarewicz@intel.com \
--cc=slawomirx.mrozowicz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).