DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] crypto/scheduler: fix name parameter parsing
@ 2017-01-30 11:19 Fan Zhang
  2017-01-30 16:46 ` De Lara Guarch, Pablo
  0 siblings, 1 reply; 2+ messages in thread
From: Fan Zhang @ 2017-01-30 11:19 UTC (permalink / raw)
  To: dev; +Cc: pablo.de.lara.guarch

This patch fixes the name parsing issue. Originally, the unique
scheduler name created by system is not passed to vdev
initializer.

Fixes: 8b483eae ("crypto/scheduler: register scheduler vdev driver")

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
 drivers/crypto/scheduler/scheduler_pmd.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/scheduler/scheduler_pmd.c b/drivers/crypto/scheduler/scheduler_pmd.c
index 62418d0..eeafbe6 100644
--- a/drivers/crypto/scheduler/scheduler_pmd.c
+++ b/drivers/crypto/scheduler/scheduler_pmd.c
@@ -116,19 +116,22 @@ static int
 cryptodev_scheduler_create(const char *name,
 	struct scheduler_init_params *init_params)
 {
-	char crypto_dev_name[RTE_CRYPTODEV_NAME_MAX_LEN];
+	char crypto_dev_name[RTE_CRYPTODEV_NAME_MAX_LEN] = {0};
 	struct rte_cryptodev *dev;
 	struct scheduler_ctx *sched_ctx;
 
 	if (init_params->def_p.name[0] == '\0') {
 		int ret = rte_cryptodev_pmd_create_dev_name(
-				init_params->def_p.name,
+				crypto_dev_name,
 				RTE_STR(CRYPTODEV_NAME_SCHEDULER_PMD));
 
 		if (ret < 0) {
 			CS_LOG_ERR("failed to create unique name");
 			return ret;
 		}
+	} else {
+		strncpy(crypto_dev_name, init_params->def_p.name,
+				RTE_CRYPTODEV_NAME_MAX_LEN - 1);
 	}
 
 	dev = rte_cryptodev_pmd_virtual_dev_init(crypto_dev_name,
-- 
2.7.4

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] crypto/scheduler: fix name parameter parsing
  2017-01-30 11:19 [dpdk-dev] [PATCH] crypto/scheduler: fix name parameter parsing Fan Zhang
@ 2017-01-30 16:46 ` De Lara Guarch, Pablo
  0 siblings, 0 replies; 2+ messages in thread
From: De Lara Guarch, Pablo @ 2017-01-30 16:46 UTC (permalink / raw)
  To: Zhang, Roy Fan, dev



> -----Original Message-----
> From: Zhang, Roy Fan
> Sent: Monday, January 30, 2017 11:19 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo
> Subject: [PATCH] crypto/scheduler: fix name parameter parsing
> 
> This patch fixes the name parsing issue. Originally, the unique
> scheduler name created by system is not passed to vdev
> initializer.
> 
> Fixes: 8b483eae ("crypto/scheduler: register scheduler vdev driver")
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---

Applied to dpdk-next-crypto and merged to "crypto/scheduler: register scheduler vdev driver".
Thanks,

Pablo

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-01-30 16:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-30 11:19 [dpdk-dev] [PATCH] crypto/scheduler: fix name parameter parsing Fan Zhang
2017-01-30 16:46 ` De Lara Guarch, Pablo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).