From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 8D985FA93 for ; Thu, 9 Feb 2017 18:02:28 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP; 09 Feb 2017 09:02:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,137,1484035200"; d="scan'208";a="63814537" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by fmsmga006.fm.intel.com with ESMTP; 09 Feb 2017 09:02:27 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.173]) by IRSMSX107.ger.corp.intel.com ([169.254.10.3]) with mapi id 14.03.0248.002; Thu, 9 Feb 2017 17:02:26 +0000 From: "De Lara Guarch, Pablo" To: "Zhang, Roy Fan" , "dev@dpdk.org" Thread-Topic: [PATCH] crypto/scheduler: fix initialization Thread-Index: AQHSgtp+JZPNj1B+zUaelaa1JYh8sKFg5fBQ Date: Thu, 9 Feb 2017 17:02:25 +0000 Message-ID: References: <1486647868-159267-1-git-send-email-roy.fan.zhang@intel.com> In-Reply-To: <1486647868-159267-1-git-send-email-roy.fan.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjhkMGFhNzEtZjA3ZS00NmNlLWI2NWEtMmM5ZGEzMzc3ODMxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IktyNlJHVm4ra0RPbUlRVlVhV1l5TnJyXC9KZmZuNW1seGxzOTZOa1NDXC9UST0ifQ== x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] crypto/scheduler: fix initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Feb 2017 17:02:29 -0000 Hi Fan, > -----Original Message----- > From: Zhang, Roy Fan > Sent: Thursday, February 09, 2017 1:44 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo > Subject: [PATCH] crypto/scheduler: fix initialization >=20 > Fixes the wrong slave initialization issue on start-up >=20 > Fixes: 100e4f7("add round-robin mode") Use the first 6 bytes of the commit SHA (12 digits). >=20 > Signed-off-by: Fan Zhang > --- > drivers/crypto/scheduler/scheduler_roundrobin.c | 16 +++++++--------- > 1 file changed, 7 insertions(+), 9 deletions(-) >=20 > diff --git a/drivers/crypto/scheduler/scheduler_roundrobin.c > b/drivers/crypto/scheduler/scheduler_roundrobin.c > index 7abdd29..ef2d683 100644 > --- a/drivers/crypto/scheduler/scheduler_roundrobin.c > +++ b/drivers/crypto/scheduler/scheduler_roundrobin.c > @@ -62,6 +62,11 @@ schedule_enqueue(void *qp_ctx, struct > rte_crypto_op **ops, uint16_t nb_ops) > rte_prefetch0(ops[i]->sym->session); >=20 > for (i =3D 0; (i < (nb_ops - 8)) && (nb_ops > 8); i +=3D 4) { > + rte_prefetch0(ops[i + 4]->sym->session); > + rte_prefetch0(ops[i + 5]->sym->session); > + rte_prefetch0(ops[i + 6]->sym->session); > + rte_prefetch0(ops[i + 7]->sym->session); > + > sess0 =3D (struct scheduler_session *) > ops[i]->sym->session->_private; > sess1 =3D (struct scheduler_session *) > @@ -80,11 +85,6 @@ schedule_enqueue(void *qp_ctx, struct > rte_crypto_op **ops, uint16_t nb_ops) > ops[i + 1]->sym->session =3D sess1->sessions[slave_idx]; > ops[i + 2]->sym->session =3D sess2->sessions[slave_idx]; > ops[i + 3]->sym->session =3D sess3->sessions[slave_idx]; > - > - rte_prefetch0(ops[i + 4]->sym->session); > - rte_prefetch0(ops[i + 5]->sym->session); > - rte_prefetch0(ops[i + 6]->sym->session); > - rte_prefetch0(ops[i + 7]->sym->session); > } I think this move should go into another patch. Thanks, Pablo