From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Jain, Deepak K" <deepak.k.jain@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] crypto: fix incorrect key setting
Date: Thu, 9 Feb 2017 23:30:51 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D897476D7C7A@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <A09C9DDE180C7E429EC68E2BFB95C9033952F8CD@IRSMSX107.ger.corp.intel.com>
> -----Original Message-----
> From: Jain, Deepak K
> Sent: Thursday, February 09, 2017 5:18 PM
> To: De Lara Guarch, Pablo; dev@dpdk.org
> Cc: De Lara Guarch, Pablo; stable@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] crypto: fix incorrect key setting
>
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> > Sent: Tuesday, February 7, 2017 10:50 PM
> > To: dev@dpdk.org
> > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> > stable@dpdk.org
> > Subject: [dpdk-dev] [PATCH] crypto: fix incorrect key setting
> >
> > When ciphering and authenticating in the same operation (cipher-then-
> auth
> > or auth-then-cipher), the cipher key and authentication key was set with
> the
> > same key, in SNOW3G, KASUMI and ZUC PMDs.
> > They were using the key of the first transform structure, instead of using
> the
> > keys of the two different transform structures.
> >
> > This is not a big issue, since usually, the same key is used for ciphering
> and
> > authentication, but keys may be different.
> >
> > Fixes: 3aafc423cf4d ("snow3g: add driver for SNOW 3G library")
> > Fixes: 2773c86d061a ("crypto/kasumi: add driver for KASUMI library")
> > Fixes: cf7685d68f00 ("crypto/zuc: add driver for ZUC library")
> >
> > CC: stable@dpdk.org
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > ---
> > drivers/crypto/kasumi/rte_kasumi_pmd.c | 4 ++--
> > drivers/crypto/snow3g/rte_snow3g_pmd.c | 4 ++--
> > drivers/crypto/zuc/rte_zuc_pmd.c | 6 ++++--
> > 3 files changed, 8 insertions(+), 6 deletions(-)
> >
> > --
> > 2.7.4
> Acked-by: Deepak Kumar Jain <deepak.k.jain@intel.com>
Applied to dpdk-next-crypto.
Pablo
prev parent reply other threads:[~2017-02-09 23:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 22:49 Pablo de Lara
2017-02-09 17:18 ` Jain, Deepak K
2017-02-09 23:30 ` De Lara Guarch, Pablo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D897476D7C7A@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=deepak.k.jain@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).