From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 93840F964; Fri, 10 Feb 2017 00:30:54 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP; 09 Feb 2017 15:30:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,138,1484035200"; d="scan'208";a="819082227" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by FMSMGA003.fm.intel.com with ESMTP; 09 Feb 2017 15:30:52 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.173]) by IRSMSX104.ger.corp.intel.com ([163.33.3.159]) with mapi id 14.03.0248.002; Thu, 9 Feb 2017 23:30:52 +0000 From: "De Lara Guarch, Pablo" To: "Jain, Deepak K" , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] crypto: fix incorrect key setting Thread-Index: AQHSgZRGxw6bq4XgJEG2J3t7aU8n7aFg7dIAgABn+wA= Date: Thu, 9 Feb 2017 23:30:51 +0000 Message-ID: References: <1486507798-47652-1-git-send-email-pablo.de.lara.guarch@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTgxZTE0ZWQtOTk3Ni00ODcwLWEzMzYtMjUyYWUwODk5MTdlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlQxUGxLbVlBb1kxQURXREJLYk9hNFVWY01oUnJweXpJb1J6cXFEYUdxQ289In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] crypto: fix incorrect key setting X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Feb 2017 23:30:55 -0000 > -----Original Message----- > From: Jain, Deepak K > Sent: Thursday, February 09, 2017 5:18 PM > To: De Lara Guarch, Pablo; dev@dpdk.org > Cc: De Lara Guarch, Pablo; stable@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] crypto: fix incorrect key setting >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara > > Sent: Tuesday, February 7, 2017 10:50 PM > > To: dev@dpdk.org > > Cc: De Lara Guarch, Pablo ; > > stable@dpdk.org > > Subject: [dpdk-dev] [PATCH] crypto: fix incorrect key setting > > > > When ciphering and authenticating in the same operation (cipher-then- > auth > > or auth-then-cipher), the cipher key and authentication key was set wit= h > the > > same key, in SNOW3G, KASUMI and ZUC PMDs. > > They were using the key of the first transform structure, instead of us= ing > the > > keys of the two different transform structures. > > > > This is not a big issue, since usually, the same key is used for cipher= ing > and > > authentication, but keys may be different. > > > > Fixes: 3aafc423cf4d ("snow3g: add driver for SNOW 3G library") > > Fixes: 2773c86d061a ("crypto/kasumi: add driver for KASUMI library") > > Fixes: cf7685d68f00 ("crypto/zuc: add driver for ZUC library") > > > > CC: stable@dpdk.org > > Signed-off-by: Pablo de Lara > > --- > > drivers/crypto/kasumi/rte_kasumi_pmd.c | 4 ++-- > > drivers/crypto/snow3g/rte_snow3g_pmd.c | 4 ++-- > > drivers/crypto/zuc/rte_zuc_pmd.c | 6 ++++-- > > 3 files changed, 8 insertions(+), 6 deletions(-) > > > > -- > > 2.7.4 > Acked-by: Deepak Kumar Jain Applied to dpdk-next-crypto. Pablo