From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Zhang, Roy Fan" <roy.fan.zhang@intel.com>,
"Doherty, Declan" <declan.doherty@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix incorrect padding addition
Date: Fri, 10 Feb 2017 00:37:34 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D897476D7DC7@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <589CB37B.7060404@intel.com>
> -----Original Message-----
> From: Zhang, Roy Fan
> Sent: Thursday, February 09, 2017 6:23 PM
> To: De Lara Guarch, Pablo; Doherty, Declan
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix incorrect
> padding addition
>
>
>
> On 09/02/2017 12:27, Pablo de Lara wrote:
> > L2fwd-crypto app was padding an incoming buffer,
> > to be aligned with the algorithm block size, in all cases.
> > This was not the right approach, as padding is only necessary
> > when using block cipher algorithms, such as AES-CBC.
> > In case of using a stream cipher algorithm, such as SNOW3G UEA2,
> > there is no need to include padding and increase the buffer size.
> >
> > Fixes: 387259bd6c67 ("examples/l2fwd-crypto: add sample application")
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> >
> Acked-by : Fan Zhang <roy.fan.zhang@intel.com>
Applied to dpdk-next-crypto.
Pablo
prev parent reply other threads:[~2017-02-10 0:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-09 12:27 Pablo de Lara
2017-02-09 18:22 ` Zhang, Roy Fan
2017-02-10 0:37 ` De Lara Guarch, Pablo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D897476D7DC7@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=roy.fan.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).