[dpdk-dev] [PATCH v3] crypto/scheduler: fix initialization

[dpdk-dev] [PATCH v3] crypto/scheduler: fix initialization

[Fan Zhang]

Fixes the wrong slave initialization issue on start-up

Fixes: 100e4f7e44ab ("crypto/scheduler: add round-robin mode")

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
 drivers/crypto/scheduler/scheduler_roundrobin.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/crypto/scheduler/scheduler_roundrobin.c b/drivers/crypto/scheduler/scheduler_roundrobin.c
index 7abdd29..1f5448e 100644
--- a/drivers/crypto/scheduler/scheduler_roundrobin.c
+++ b/drivers/crypto/scheduler/scheduler_roundrobin.c
@@ -350,7 +350,6 @@ static int
 scheduler_start(struct rte_cryptodev *dev)
 {
 	struct scheduler_ctx *sched_ctx = dev->data->dev_private;
-
 	uint16_t i;
 
 	for (i = 0; i < dev->data->nb_queue_pairs; i++) {
@@ -358,14 +357,13 @@ scheduler_start(struct rte_cryptodev *dev)
 		struct rr_scheduler_qp_ctx *rr_qp_ctx =
 				qp_ctx->private_qp_ctx;
 		uint32_t j;
-		uint16_t qp_id = rr_qp_ctx->slaves[0].qp_id;
 
 		memset(rr_qp_ctx->slaves, 0, MAX_SLAVES_NUM *
 				sizeof(struct scheduler_slave));
 		for (j = 0; j < sched_ctx->nb_slaves; j++) {
 			rr_qp_ctx->slaves[j].dev_id =
-					sched_ctx->slaves[i].dev_id;
-			rr_qp_ctx->slaves[j].qp_id = qp_id;
+					sched_ctx->slaves[j].dev_id;
+			rr_qp_ctx->slaves[j].qp_id = i;
 		}
 
 		rr_qp_ctx->nb_slaves = sched_ctx->nb_slaves;
-- 
v3:
Updated "Fixes" message

v2:
remove committed lines of code not relating to the topic
2.7.4

Re: [dpdk-dev] [PATCH v3] crypto/scheduler: fix initialization

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: Zhang, Roy Fan
> Sent: Thursday, February 09, 2017 6:50 PM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo
> Subject: [PATCH v3] crypto/scheduler: fix initialization
> 
> Fixes the wrong slave initialization issue on start-up
> 
> Fixes: 100e4f7e44ab ("crypto/scheduler: add round-robin mode")
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>

Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Re: [dpdk-dev] [PATCH v3] crypto/scheduler: fix initialization

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of De Lara Guarch,
> Pablo
> Sent: Friday, February 10, 2017 1:49 PM
> To: Zhang, Roy Fan; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3] crypto/scheduler: fix initialization
> 
> 
> 
> > -----Original Message-----
> > From: Zhang, Roy Fan
> > Sent: Thursday, February 09, 2017 6:50 PM
> > To: dev@dpdk.org
> > Cc: De Lara Guarch, Pablo
> > Subject: [PATCH v3] crypto/scheduler: fix initialization
> >
> > Fixes the wrong slave initialization issue on start-up
> >
> > Fixes: 100e4f7e44ab ("crypto/scheduler: add round-robin mode")
> >
> > Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> 
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Applied to dpdk-next-crypto.
Thanks,

Pablo