From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pablo.de.lara.guarch@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id C624F5583
 for <dev@dpdk.org>; Thu, 16 Feb 2017 11:55:08 +0100 (CET)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by orsmga105.jf.intel.com with ESMTP; 16 Feb 2017 02:55:07 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.35,168,1484035200"; d="scan'208";a="934570296"
Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159])
 by orsmga003.jf.intel.com with ESMTP; 16 Feb 2017 02:55:07 -0800
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.173]) by
 IRSMSX104.ger.corp.intel.com ([163.33.3.159]) with mapi id 14.03.0248.002;
 Thu, 16 Feb 2017 10:55:06 +0000
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Mrzyglod, DanielX T" <danielx.t.mrzyglod@intel.com>, "Mrozowicz,
 SlawomirX" <slawomirx.mrozowicz@intel.com>, "Doherty, Declan"
 <declan.doherty@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [PATCH] app/crypto-perf: fix for segfault when bad optype is
 used with gcm alghorithms
Thread-Index: AQHSiELl7s4We7qVf0yAwq8ppUNpY6FrdXtQ
Date: Thu, 16 Feb 2017 10:55:05 +0000
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D897476DC4A4@IRSMSX108.ger.corp.intel.com>
References: <1487242128-154609-1-git-send-email-danielx.t.mrzyglod@intel.com>
In-Reply-To: <1487242128-154609-1-git-send-email-danielx.t.mrzyglod@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWI5YzZlZmItNjIyZS00OWNhLWJmYWYtYmMyOTU2MTRlNGM1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjlYeDJQVW1PaGI3dWQrV1RvUnZBXC9oXC9DT2xraGx6N2xWK1VuNU5yYWkwRT0ifQ==
x-ctpclassification: CTP_IC
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] app/crypto-perf: fix for segfault when bad
 optype is used with gcm alghorithms
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Feb 2017 10:55:09 -0000

Hi Daniel,

> -----Original Message-----
> From: Mrzyglod, DanielX T
> Sent: Thursday, February 16, 2017 10:49 AM
> To: Mrozowicz, SlawomirX; Doherty, Declan; De Lara Guarch, Pablo
> Cc: dev@dpdk.org; Mrzyglod, DanielX T
> Subject: [PATCH] app/crypto-perf: fix for segfault when bad optype is use=
d
> with gcm alghorithms
>=20
> When somebody use bad --optype with aead alghorithms
> segmentation fault could happen.
>=20
> Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test
> application")
>=20
> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>

There is a checkpatch error:

ERROR:SPACING: space prohibited before that close parenthesis ')'
#75: FILE: app/test-crypto-perf/cperf_options_parsing.c:834:
+			options->auth_algo =3D=3D RTE_CRYPTO_AUTH_AES_GMAC ) {

Thanks,
Pablo