From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id E88D63B5 for ; Tue, 21 Mar 2017 16:41:40 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP; 21 Mar 2017 08:41:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,198,1486454400"; d="scan'208";a="946667502" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by orsmga003.jf.intel.com with ESMTP; 21 Mar 2017 08:41:23 -0700 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by IRSMSX106.ger.corp.intel.com (163.33.3.31) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 21 Mar 2017 15:40:54 +0000 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.173]) by irsmsx111.ger.corp.intel.com ([169.254.2.242]) with mapi id 14.03.0248.002; Tue, 21 Mar 2017 15:40:54 +0000 From: "De Lara Guarch, Pablo" To: Akhil Goyal , "dev@dpdk.org" CC: "thomas.monjalon@6wind.com" , "Doherty, Declan" , "Mcnamara, John" , "nhorman@tuxdriver.com" , "hemant.agrawal@nxp.com" Thread-Topic: [PATCH v5 02/12] crypto/dpaa2_sec: add dpaa2 sec poll mode driver Thread-Index: AQHSlCndjgtFpXa0YkKwkkL6zOYt7aGfhgcA Date: Tue, 21 Mar 2017 15:40:53 +0000 Message-ID: References: <20170303193648.30665-1-akhil.goyal@nxp.com> <20170303194935.30831-1-akhil.goyal@nxp.com> <20170303194935.30831-3-akhil.goyal@nxp.com> In-Reply-To: <20170303194935.30831-3-akhil.goyal@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGRjNWYxNDctYzdlOS00YWU4LWJkN2YtOTM1MTkzMjhmOGRjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjBWRHpMSkMwYWh6VHJuelVnWEczUCs3NzFtMVVVZ21uZ0tER1FvcEVRUzg9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 02/12] crypto/dpaa2_sec: add dpaa2 sec poll mode driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Mar 2017 15:41:41 -0000 > -----Original Message----- > From: Akhil Goyal [mailto:akhil.goyal@nxp.com] > Sent: Friday, March 03, 2017 7:49 PM > To: dev@dpdk.org > Cc: thomas.monjalon@6wind.com; Doherty, Declan; De Lara Guarch, Pablo; > Mcnamara, John; nhorman@tuxdriver.com; hemant.agrawal@nxp.com; > Akhil Goyal > Subject: [PATCH v5 02/12] crypto/dpaa2_sec: add dpaa2 sec poll mode > driver >=20 > Signed-off-by: Hemant Agrawal > Signed-off-by: Akhil Goyal ... > --- /dev/null > +++ b/drivers/crypto/dpaa2_sec/Makefile > @@ -0,0 +1,81 @@ ... > +# build flags > +ifeq ($(CONFIG_RTE_LIBRTE_DPAA2_SEC_DEBUG_INIT),y) > +CFLAGS +=3D -O0 -g > +CFLAGS +=3D "-Wno-error" > +else > +CFLAGS +=3D -O3 > +CFLAGS +=3D $(WERROR_FLAGS) > +endif > +CFLAGS +=3D "-Wno-strict-aliasing" Is this "Wno-strict-aliasing" necessary? Is any gcc version complaining abo= ut this? If yes, could you add a comment about it? ... > diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > new file mode 100644 > index 0000000..34ca776 > --- /dev/null > +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c ... > + > +#include > +#include Add blank line here, to separate glibc libraries and DPDK libraries. > +#include > +#include ... > diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h > b/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h > new file mode 100644 > index 0000000..e0d6148 > --- /dev/null > +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h > @@ -0,0 +1,225 @@ > +/*- > + * BSD LICENSE > + * > + * Copyright (c) 2016 Freescale Semiconductor, Inc. All rights reserve= d. > + * Copyright (c) 2016 NXP. All rights reserved. ... > +/** private data structure for each DPAA2_SEC device */ > +struct dpaa2_sec_dev_private { > + void *mc_portal; /**< MC Portal for configuring this device */ > + void *hw; /**< Hardware handle for this device.Used by NADK > framework */ > + int32_t hw_id; /**< An unique ID of this device instance */ > + int32_t vfio_fd; /**< File descriptor received via VFIO */ > + uint16_t token; /**< Token required by DPxxx objects */ > + unsigned int max_nb_queue_pairs; Missing comment here? > + > + unsigned int max_nb_sessions; > + /**< Max number of sessions supported by device */ > +}; > + > +struct dpaa2_sec_qp { > + struct dpaa2_queue rx_vq; > + struct dpaa2_queue tx_vq; > +}; > +