From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 873ABDE5 for ; Wed, 29 Mar 2017 18:12:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490803979; x=1522339979; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=wFAuzYxeowqyEqp7WDi1dkvui8a8IV+YfmXOyFAoSK8=; b=uzimeR0kHKCVz46Kma8u9uKbFnmIhSjmoJ9KOLIUVpitvJF/fLlZN3Ms RqN2oa7Da2VghsP98pfGVJXCkDFOxg==; Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Mar 2017 09:12:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,241,1486454400"; d="scan'208";a="1148430541" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by fmsmga002.fm.intel.com with ESMTP; 29 Mar 2017 09:12:57 -0700 Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by IRSMSX151.ger.corp.intel.com (163.33.192.59) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 29 Mar 2017 17:12:56 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.239]) by IRSMSX156.ger.corp.intel.com ([169.254.3.246]) with mapi id 14.03.0319.002; Wed, 29 Mar 2017 17:12:56 +0100 From: "De Lara Guarch, Pablo" To: "Singh, Jasvinder" , "dev@dpdk.org" CC: "olivier.matz@6wind.com" , "Doherty, Declan" Thread-Topic: [PATCH v6 2/2] test/test: add unit test for CRC computation Thread-Index: AQHSqIiGsfWu2heyREOSKIOw4/vY4qGr/B3w Date: Wed, 29 Mar 2017 16:12:55 +0000 Message-ID: References: <1490107540-66614-2-git-send-email-jasvinder.singh@intel.com> <1490791332-126476-1-git-send-email-jasvinder.singh@intel.com> <1490791332-126476-3-git-send-email-jasvinder.singh@intel.com> In-Reply-To: <1490791332-126476-3-git-send-email-jasvinder.singh@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTIwNTAwZDctYjdlZS00YzUxLTgxYzktY2UzZTJiYjQ0OTkyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Ijc4S3ZkSUtScU5XbklMT011Z0lCSGcwNWdLQkRxZU1jMFVmQ3RBcURQZzg9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 2/2] test/test: add unit test for CRC computation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Mar 2017 16:12:59 -0000 Hi Jasvinder, > -----Original Message----- > From: Singh, Jasvinder > Sent: Wednesday, March 29, 2017 1:42 PM > To: dev@dpdk.org > Cc: olivier.matz@6wind.com; Doherty, Declan; De Lara Guarch, Pablo > Subject: [PATCH v6 2/2] test/test: add unit test for CRC computation >=20 > This patch provides a set of tests for verifying the functional > correctness of 16-bit and 32-bit CRC APIs. >=20 > Signed-off-by: Jasvinder Singh > --- > test/test/Makefile | 2 + > test/test/test_crc.c | 241 > +++++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 243 insertions(+) > create mode 100644 test/test/test_crc.c >=20 ... > diff --git a/test/test/test_crc.c b/test/test/test_crc.c > new file mode 100644 > index 0000000..c25790d > --- /dev/null > +++ b/test/test/test_crc.c > @@ -0,0 +1,241 @@ ... > +static int > +test_crc_scalar(void) Could you merge this and the next function in a single one, as they are duplicated (except for the comments/printfs, which can be a par= ameter of the function). Apart from this: Acked-by: Pablo de Lara