From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 72CB72E8A for ; Wed, 12 Apr 2017 17:22:27 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Apr 2017 08:22:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,191,1488873600"; d="scan'208";a="86579795" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by orsmga005.jf.intel.com with ESMTP; 12 Apr 2017 08:22:25 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.239]) by IRSMSX153.ger.corp.intel.com ([163.33.192.75]) with mapi id 14.03.0319.002; Wed, 12 Apr 2017 16:22:25 +0100 From: "De Lara Guarch, Pablo" To: Thomas Monjalon CC: "dev@dpdk.org" , "olivier.matz@6wind.com" Thread-Topic: [dpdk-dev] [PATCH] eal: redefine logtype values Thread-Index: AQHSs5ctF0q2rG3DEk2khxMf4UVROqHBx2sAgAASVzA= Date: Wed, 12 Apr 2017 15:22:24 +0000 Message-ID: References: <1492006471-114636-1-git-send-email-pablo.de.lara.guarch@intel.com> <11937147.4rRz3cW7Er@xps13> In-Reply-To: <11937147.4rRz3cW7Er@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWFkYjA3ZjUtOGZiNC00YWJkLWIzYTEtMWI4NzNlZjRlNTExIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InNWeEdKY1dMaDZseEVqdENLcTV1NE5lYTF4QmFuZHdsMFk4ZVZSZWsyK3c9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] eal: redefine logtype values X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Apr 2017 15:22:29 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, April 12, 2017 4:16 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; olivier.matz@6wind.com > Subject: Re: [dpdk-dev] [PATCH] eal: redefine logtype values >=20 > 2017-04-12 15:14, Pablo de Lara: > > After the changes in commit c1b5fa94a46f > > ("eal: support dynamic log types"), logtype is not treated as a > > bitmask, but a decimal value. Therefore, values have to be > > converted. > > > > Fixes: c1b5fa94a46f ("eal: support dynamic log types") > > > > Signed-off-by: Pablo de Lara > [...] > > /* SDK log type, keep sync'd with rte_log_init() */ > [...] > > +#define RTE_LOGTYPE_EAL 0 /**< Log related to eal. */ > > +#define RTE_LOGTYPE_MALLOC 1 /**< Log related to malloc. */ > > +#define RTE_LOGTYPE_RING 2 /**< Log related to ring. */ > > +#define RTE_LOGTYPE_MEMPOOL 3 /**< Log related to mempool. */ > > +#define RTE_LOGTYPE_TIMER 4 /**< Log related to timers. */ > > +#define RTE_LOGTYPE_PMD 5 /**< Log related to poll mode driver. > */ > > +#define RTE_LOGTYPE_HASH 6 /**< Log related to hash table. */ > > +#define RTE_LOGTYPE_LPM 7 /**< Log related to LPM. */ > > +#define RTE_LOGTYPE_KNI 8 /**< Log related to KNI. */ > > +#define RTE_LOGTYPE_ACL 9 /**< Log related to ACL. */ > > +#define RTE_LOGTYPE_POWER 10 /**< Log related to power. */ > > +#define RTE_LOGTYPE_METER 11 /**< Log related to QoS meter. */ > > +#define RTE_LOGTYPE_SCHED 12 /**< Log related to QoS port > scheduler. */ > > +#define RTE_LOGTYPE_PORT 13 /**< Log related to port. */ > > +#define RTE_LOGTYPE_TABLE 14 /**< Log related to table. */ > > +#define RTE_LOGTYPE_PIPELINE 15 /**< Log related to pipeline. */ > > +#define RTE_LOGTYPE_MBUF 16 /**< Log related to mbuf. */ > > +#define RTE_LOGTYPE_CRYPTODEV 17 /**< Log related to cryptodev. */ > > +#define RTE_LOGTYPE_EFD 18 /**< Log related to EFD. */ > > +#define RTE_LOGTYPE_EVENTDEV 19 /**< Log related to eventdev. */ >=20 > I think you should use these values in rte_log_init, > instead of the hardcoded ones. > So the messages about keeping them sync'd could be removed :) Good idea, will send a v2 shortly.