From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id B3BDF316B for ; Thu, 13 Apr 2017 15:43:05 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Apr 2017 06:43:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,194,1488873600"; d="scan'208";a="1135031936" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by fmsmga001.fm.intel.com with ESMTP; 13 Apr 2017 06:43:03 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.239]) by IRSMSX153.ger.corp.intel.com ([163.33.192.75]) with mapi id 14.03.0319.002; Thu, 13 Apr 2017 14:43:02 +0100 From: "De Lara Guarch, Pablo" To: Stephen Hemminger CC: "olivier.matz@6wind.com" , "thomas.monjalon@6wind.com" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] eal: redefine logtype values Thread-Index: AQHSs6J0Kn/eiaxB5UqvpGeKIGp5bqHCMviAgAEYjiA= Date: Thu, 13 Apr 2017 13:43:02 +0000 Message-ID: References: <1492006471-114636-1-git-send-email-pablo.de.lara.guarch@intel.com> <1492011332-5846-1-git-send-email-pablo.de.lara.guarch@intel.com> <20170412144111.2d6bb7d8@xeon-e3> In-Reply-To: <20170412144111.2d6bb7d8@xeon-e3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDdhNTI3NDctYmFmOC00NThkLThiODUtNDZhNjExNmRjNzk4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImQ3N0F2akRrczJpdE9lXC9MMTBpakJlbTJUUExVa1lZRWdGQlRQZlNPRGhvPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] eal: redefine logtype values X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Apr 2017 13:43:06 -0000 > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Wednesday, April 12, 2017 10:41 PM > To: De Lara Guarch, Pablo > Cc: olivier.matz@6wind.com; thomas.monjalon@6wind.com; > dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] eal: redefine logtype values >=20 > On Wed, 12 Apr 2017 16:35:32 +0100 > Pablo de Lara wrote: >=20 > > + /* register legacy log types */ > > + __rte_log_register("eal", RTE_LOGTYPE_EAL); > > + __rte_log_register("malloc", RTE_LOGTYPE_MALLOC); > > + __rte_log_register("ring", RTE_LOGTYPE_RING); > > + __rte_log_register("mempool", RTE_LOGTYPE_MEMPOOL); > > + __rte_log_register("timer", RTE_LOGTYPE_TIMER); > > + __rte_log_register("pmd", RTE_LOGTYPE_PMD); > > + __rte_log_register("hash", RTE_LOGTYPE_HASH); > > + __rte_log_register("lpm", RTE_LOGTYPE_LPM); > > + __rte_log_register("kni", RTE_LOGTYPE_KNI); > > + __rte_log_register("acl", RTE_LOGTYPE_ACL); > > + __rte_log_register("power", RTE_LOGTYPE_POWER); > > + __rte_log_register("meter", RTE_LOGTYPE_METER); > > + __rte_log_register("sched", RTE_LOGTYPE_SCHED); > > + __rte_log_register("port", RTE_LOGTYPE_PORT); > > + __rte_log_register("table", RTE_LOGTYPE_TABLE); > > + __rte_log_register("pipeline", RTE_LOGTYPE_PIPELINE); > > + __rte_log_register("mbuf", RTE_LOGTYPE_MBUF); > > + __rte_log_register("cryptodev", RTE_LOGTYPE_CRYPTODEV); > > + __rte_log_register("efd", RTE_LOGTYPE_EFD); > > + __rte_log_register("eventdev", RTE_LOGTYPE_EVENTDEV); > > + __rte_log_register("user1", RTE_LOGTYPE_USER1); > > + __rte_log_register("user2", RTE_LOGTYPE_USER2); > > + __rte_log_register("user3", RTE_LOGTYPE_USER3); > > + __rte_log_register("user4", RTE_LOGTYPE_USER4); > > + __rte_log_register("user5", RTE_LOGTYPE_USER5); > > + __rte_log_register("user6", RTE_LOGTYPE_USER6); > > + __rte_log_register("user7", RTE_LOGTYPE_USER7); > > + __rte_log_register("user8", RTE_LOGTYPE_USER8); >=20 > Why is this not a table rather than code? > Data driven design is better. Hi Stephen, I just sent a v3 with your change proposed. Thanks! Pablo