From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 9BF54374E for ; Tue, 2 May 2017 13:18:55 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 May 2017 04:18:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,404,1488873600"; d="scan'208";a="851975394" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by FMSMGA003.fm.intel.com with ESMTP; 02 May 2017 04:18:53 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.239]) by IRSMSX102.ger.corp.intel.com ([169.254.2.153]) with mapi id 14.03.0319.002; Tue, 2 May 2017 12:18:52 +0100 From: "De Lara Guarch, Pablo" To: Thomas Monjalon , "Patil, Harish" , "Horton, Remy" CC: "dev@dpdk.org" , "Wu, Jingjing" Thread-Topic: [dpdk-dev] [PATCH v2] app/testpmd: add bitrate stats option Thread-Index: AQHSwA6t9lQ37ULuM0S1gSz4zFvLsaHf3F0AgAAEDQCAAQj4gA== Date: Tue, 2 May 2017 11:18:52 +0000 Message-ID: References: <1493211774-28249-1-git-send-email-remy.horton@intel.com> <1493377213-156955-1-git-send-email-pablo.de.lara.guarch@intel.com> <1984316.gczFh5jcb3@xps> In-Reply-To: <1984316.gczFh5jcb3@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTRiY2JmMWItOTc1MC00OTg2LWE3YmEtN2Q1N2ZiNzM4MmRjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InFMQ0xLeHFHeXNJaXFOXC9IajBxV1RZa1ZxUVwvRWExS3pvZjA5aVRQaWhmdz0ifQ== x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: add bitrate stats option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 May 2017 11:18:56 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Monday, May 01, 2017 9:22 PM > To: Patil, Harish; Horton, Remy > Cc: dev@dpdk.org; De Lara Guarch, Pablo; Wu, Jingjing > Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: add bitrate stats option >=20 > 01/05/2017 22:07, Patil, Harish: > > Hi Remy, > > Have a small suggestion here. > > Since testpmd uses new libraries of librte_latencystats and > > librte_bitratestats it hurts packet processing performance. > > Many users who use testpmd to do the initial performance benchmarks > may > > not be aware of such a feature is default enabled. >=20 > Yes, the default config of testpmd must give good performance. >=20 > > So can we disable this feature by default in the config? > > * CONFIG_RTE_LIBRTE_BITRATE=3Dn > > * CONFIG_RTE_LIBRTE_LATENCY_STATS=3Dn > > Only those folks interested in latency/jitter measurements can recompil= e > > with those configs enabled. >=20 > I disagree about compile-time options. > It should be a run-time option of testpmd. >=20 > Please Remy (or others), > disable the metrics in the default configuration of testpmd, > before the 17.05 release. > You have few days, it is urgent. Bitrate stats are disabled by default, in testpmd. I assume that the code that you want to avoid is: for (sm_id =3D 0; sm_id < nb_fs; sm_id++) (*pkt_fwd)(fsm[sm_id]); #ifdef RTE_LIBRTE_BITRATE if (bitrate_enabled !=3D 0 && bitrate_lcore_id =3D=3D rte_lcore_id()) { tics_current =3D rte_rdtsc(); if (tics_current - tics_datum >=3D tics_per_1sec) { Unless --bitrate-stats is used, bitrate_enabled =3D 0, so all this code won= 't be run. I can send a patch to check the latencystats_enabled flag first, following = the approach above, here: #ifdef RTE_LIBRTE_LATENCY_STATS if (latencystats_lcore_id =3D=3D rte_lcore_id()) Thanks, Pablo