From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 5CCBC2BE1 for ; Tue, 27 Jun 2017 11:51:10 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP; 27 Jun 2017 02:51:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,399,1493708400"; d="scan'208";a="985644137" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by orsmga003.jf.intel.com with ESMTP; 27 Jun 2017 02:51:09 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.133]) by irsmsx105.ger.corp.intel.com ([169.254.7.168]) with mapi id 14.03.0319.002; Tue, 27 Jun 2017 10:51:08 +0100 From: "De Lara Guarch, Pablo" To: Thomas Monjalon , "Doherty, Declan" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 06/12] cryptodev: move vdev functions to a separate file Thread-Index: AQHS6pqkZHbD3jElJEKLp+w7R8f7KqIyWUqAgAVpRYCAALflYA== Date: Tue, 27 Jun 2017 09:51:07 +0000 Message-ID: References: <1495639634-74846-1-git-send-email-pablo.de.lara.guarch@intel.com> <20170621062826.21896-7-pablo.de.lara.guarch@intel.com> <2058861.mNNx7DgSpj@xps> In-Reply-To: <2058861.mNNx7DgSpj@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 06/12] cryptodev: move vdev functions to a separate file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jun 2017 09:51:11 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Tuesday, June 27, 2017 12:31 AM > To: Doherty, Declan ; De Lara Guarch, Pablo > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 06/12] cryptodev: move vdev functions > to a separate file >=20 > 23/06/2017 14:52, Declan Doherty: > > On 21/06/2017 7:28 AM, Pablo de Lara wrote: > > > Move all functions handling virtual devices to a separate header > > > file "rte_cryptodev_vdev.h", in order to leave only generic > > > functions for any device in the rest of the files. > > > > > > Signed-off-by: Pablo de Lara > > > > Acked-by: Declan Doherty >=20 > This patch is moving some code from a .c to a .h. > The consequence is that driver are now compiling new functions from the .= h > and require librte_kvargs to link with. > It is a build error in shared lib mode. >=20 > Please keep the code in a .c file if possible. Sorry about this. I just fixed it in the subtree, so pull it whenever you a= re ready. Also, since ethdev have separated pci and vdev functions in separate .h fil= es, I preferred to be consistent and do the same. Thanks, Pablo