From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 8E95D2C8 for ; Tue, 27 Jun 2017 19:11:39 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP; 27 Jun 2017 10:11:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,271,1496127600"; d="scan'208";a="119852979" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by fmsmga006.fm.intel.com with ESMTP; 27 Jun 2017 10:11:37 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.133]) by irsmsx105.ger.corp.intel.com ([169.254.7.168]) with mapi id 14.03.0319.002; Tue, 27 Jun 2017 18:11:36 +0100 From: "De Lara Guarch, Pablo" To: Thomas Monjalon , "Yigit, Ferruh" CC: "dev@dpdk.org" , "Doherty, Declan" Thread-Topic: [dpdk-dev] [PATCH v2 06/12] cryptodev: move vdev functions to a separate file Thread-Index: AQHS6pqkZHbD3jElJEKLp+w7R8f7KqIyWUqAgAVpRYCAALflYIAAQtIAgAAL7gCAABA5gIAAIiYQ Date: Tue, 27 Jun 2017 17:11:36 +0000 Message-ID: References: <1495639634-74846-1-git-send-email-pablo.de.lara.guarch@intel.com> <1703981.y8KKVdfaY4@xps> <8d33a2ad-b80c-1337-0db3-88aa5e6fcb07@intel.com> <1580410.hOtKtBbxIg@xps> In-Reply-To: <1580410.hOtKtBbxIg@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 06/12] cryptodev: move vdev functions to a separate file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jun 2017 17:11:40 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Tuesday, June 27, 2017 5:09 PM > To: Yigit, Ferruh > Cc: dev@dpdk.org; De Lara Guarch, Pablo > ; Doherty, Declan > > Subject: Re: [dpdk-dev] [PATCH v2 06/12] cryptodev: move vdev functions > to a separate file >=20 > 27/06/2017 17:11, Ferruh Yigit: > > On 6/27/2017 3:28 PM, Thomas Monjalon wrote: > > > 27/06/2017 11:51, De Lara Guarch, Pablo: > > >> From: Thomas Monjalon [mailto:thomas@monjalon.net] > > >>> 23/06/2017 14:52, Declan Doherty: > > >>>> On 21/06/2017 7:28 AM, Pablo de Lara wrote: > > >>>>> Move all functions handling virtual devices to a separate header > > >>>>> file "rte_cryptodev_vdev.h", in order to leave only generic > > >>>>> functions for any device in the rest of the files. > > >>>>> > > >>>>> Signed-off-by: Pablo de Lara > > >>>> > > >>>> Acked-by: Declan Doherty > > >>> > > >>> This patch is moving some code from a .c to a .h. > > >>> The consequence is that driver are now compiling new functions > > >>> from the .h and require librte_kvargs to link with. > > >>> It is a build error in shared lib mode. > > >>> > > >>> Please keep the code in a .c file if possible. > > >> > > >> Sorry about this. I just fixed it in the subtree, so pull it wheneve= r you > are ready. > > >> Also, since ethdev have separated pci and vdev functions in > > >> separate .h files, I preferred to be consistent and do the same. > > > > > > There is no reason to implement these functions in .h files. > > > I prefer to keep them in a .c file and just export the proto in .h. > > > > This is same in the eth_dev too. > > > > These are helper functions, and implementing them in .h file has the > > benefit of function goes into PMD library, and there is no dependency > > from PMDs to librte_ether for these functions (there are dependencies > > for other functions ..). > > > > It looks acceptable for me for helper functions to be implemented in > > header file. But if we decide to move them into .c file, .map file > > should be updated to export them, and I suppose ethdev also should be > > updated to be compatible. >=20 > Yes we should avoid adding code in .h. > It is accepted only for performance reasons. > ethdev can be reworked later. > cryptodev can be improved now and avoid adding rte_devargs deps on > PMDs. Ok, will make those changes shortly. Pablo