From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 196B73257 for ; Wed, 12 Jul 2017 15:07:29 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jul 2017 06:07:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,349,1496127600"; d="scan'208";a="878017674" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by FMSMGA003.fm.intel.com with ESMTP; 12 Jul 2017 06:07:27 -0700 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by IRSMSX154.ger.corp.intel.com (163.33.192.96) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 12 Jul 2017 14:07:27 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.133]) by irsmsx155.ger.corp.intel.com ([169.254.14.182]) with mapi id 14.03.0319.002; Wed, 12 Jul 2017 14:07:26 +0100 From: "De Lara Guarch, Pablo" To: "De Lara Guarch, Pablo" , Jan Blunck , "dev@dpdk.org" CC: "Doherty, Declan" Thread-Topic: [dpdk-dev] [PATCH 2/2] cryptodev: rework cryptodev PMD init to not require rte_vdev.h Thread-Index: AQHS+uUGfvlkSmULlUGjH/90fxk/aaJQIVgggAAIHIA= Date: Wed, 12 Jul 2017 13:07:26 +0000 Message-ID: References: <20170712075940.58559-1-jblunck@infradead.org> <20170712075940.58559-3-jblunck@infradead.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/2] cryptodev: rework cryptodev PMD init to not require rte_vdev.h X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Jul 2017 13:07:30 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Wednesday, July 12, 2017 1:40 PM > To: Jan Blunck ; dev@dpdk.org > Cc: Doherty, Declan > Subject: Re: [dpdk-dev] [PATCH 2/2] cryptodev: rework cryptodev PMD init > to not require rte_vdev.h >=20 >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jan Blunck > > Sent: Wednesday, July 12, 2017 9:00 AM > > To: dev@dpdk.org > > Cc: Doherty, Declan > > Subject: [dpdk-dev] [PATCH 2/2] cryptodev: rework cryptodev PMD init > > to not require rte_vdev.h > > > > This reworks the library code so that it doesn't require to include > > rte_vdev.h. This is a preparation to move the vdev bus into a > > standalone library. > > > > Signed-off-by: Jan Blunck >=20 > ... >=20 > > diff --git a/lib/librte_cryptodev/rte_cryptodev_vdev.h > > b/lib/librte_cryptodev/rte_cryptodev_vdev.h > > index 94ab9d33d..a877eed74 100644 > > --- a/lib/librte_cryptodev/rte_cryptodev_vdev.h > > +++ b/lib/librte_cryptodev/rte_cryptodev_vdev.h > > @@ -33,7 +33,6 @@ > > #ifndef _RTE_CRYPTODEV_VDEV_H_ > > #define _RTE_CRYPTODEV_VDEV_H_ > > > > -#include > > #include > > > > #include "rte_cryptodev.h" > > @@ -72,15 +71,15 @@ struct rte_crypto_vdev_init_params { > > * @param name PMD type name > > * @param dev_private_size Size of crypto PMDs private data > > * @param socket_id Socket to allocate resources on. > > - * @param vdev Pointer to virtual device structure. > > + * @param dev Pointer to device structure. > > * > > * @return > > * - Cryptodev pointer if device is successfully created. > > * - NULL if device cannot be created. > > */ > > struct rte_cryptodev * > > -rte_cryptodev_vdev_pmd_init(const char *name, size_t > dev_private_size, > > - int socket_id, struct rte_vdev_device *vdev); > > +rte_cryptodev_pmd_init(const char *name, size_t dev_private_size, > > + int socket_id, struct rte_device *dev); >=20 > Hi Jan, >=20 > Even though now this function does not require the rte_vdev_device > structure, I would still call it rte_cryptodev_vdev_pmd_init, as it is us= ed for > virtual crypto devices and not physical ones. >=20 > The rest look ok to me. Just another note. Check-git-log.sh complains about the title: Wrong headline format: cryptodev: rework cryptodev PMD init to not require rte_vdev.h Headline too long: cryptodev: rework cryptodev PMD init to not require rte_vdev.h So this needs some rework (e.g. no need to use cryptodev word again). Thanks, Pablo >=20 > Thanks, > Pablo