From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 9ECDB20F for ; Sat, 15 Jul 2017 13:04:48 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jul 2017 04:04:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,363,1496127600"; d="scan'208";a="127017054" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by fmsmga005.fm.intel.com with ESMTP; 15 Jul 2017 04:04:46 -0700 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by IRSMSX153.ger.corp.intel.com (163.33.192.75) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sat, 15 Jul 2017 12:04:45 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.133]) by irsmsx155.ger.corp.intel.com ([169.254.14.182]) with mapi id 14.03.0319.002; Sat, 15 Jul 2017 12:04:44 +0100 From: "De Lara Guarch, Pablo" To: Jan Blunck , "dev@dpdk.org" CC: "Doherty, Declan" Thread-Topic: [PATCH v2 3/4] cryptodev: rework PMD init to not require rte_vdev.h Thread-Index: AQHS+0lWkeSHr/Qkd06ZsxvLnGo6xKJUu5UQ Date: Sat, 15 Jul 2017 11:04:44 +0000 Message-ID: References: <20170712075940.58559-1-jblunck@infradead.org> <20170712195846.65286-1-jblunck@infradead.org> <20170712195846.65286-4-jblunck@infradead.org> In-Reply-To: <20170712195846.65286-4-jblunck@infradead.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 3/4] cryptodev: rework PMD init to not require rte_vdev.h X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Jul 2017 11:04:49 -0000 Hi > -----Original Message----- > From: Jan Blunck [mailto:jblunck@gmail.com] On Behalf Of Jan Blunck > Sent: Wednesday, July 12, 2017 8:59 PM > To: dev@dpdk.org > Cc: Doherty, Declan ; De Lara Guarch, Pablo > > Subject: [PATCH v2 3/4] cryptodev: rework PMD init to not require > rte_vdev.h >=20 > The rte_cryptodev_vdev_pmd_init() is a helper for vdev-based drivers. > By moving the helper to the header we don't require rte_vdev.h at build- > time of the librte_cryptodev library. This is a preparation to move the v= dev > bus into a standalone library. >=20 > Signed-off-by: Jan Blunck I am seeing some clang errors when applying this patch: lib/librte_cryptodev/rte_cryptodev_vdev.h:88:14: error: implicit declaratio= n of function 'rte_cryptodev_pmd_allocate' is invalid in C99 [-Werror,-Wimplicit-function= -declaration] cryptodev =3D rte_cryptodev_pmd_allocate(name, socket_id); ^ lib/librte_cryptodev/rte_cryptodev_vdev.h:88:12: error: incompatible intege= r to pointer conversion assigning to 'struct rte_cryptodev *' from 'int' [-Werror,-Wint-= conversion] cryptodev =3D rte_cryptodev_pmd_allocate(name, socket_id); Also, looks like git commit title is not correct, according to check-git-lo= g.sh: Wrong headline format: cryptodev: rework PMD init to not require rte_vdev.h Pablo