From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 807107CAA for ; Mon, 4 Sep 2017 16:32:04 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Sep 2017 07:32:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,475,1498546800"; d="scan'208";a="307781757" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga004.fm.intel.com with ESMTP; 04 Sep 2017 07:32:02 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.167]) by IRSMSX102.ger.corp.intel.com ([169.254.2.59]) with mapi id 14.03.0319.002; Mon, 4 Sep 2017 15:32:01 +0100 From: "De Lara Guarch, Pablo" To: "De Lara Guarch, Pablo" , Jan Blunck , "dev@dpdk.org" CC: "Doherty, Declan" Thread-Topic: [PATCH v2 3/4] cryptodev: rework PMD init to not require rte_vdev.h Thread-Index: AQHS+0lWkeSHr/Qkd06ZsxvLnGo6xKJUu5UQgFBi1zA= Date: Mon, 4 Sep 2017 14:32:01 +0000 Message-ID: References: <20170712075940.58559-1-jblunck@infradead.org> <20170712195846.65286-1-jblunck@infradead.org> <20170712195846.65286-4-jblunck@infradead.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 3/4] cryptodev: rework PMD init to not require rte_vdev.h X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Sep 2017 14:32:05 -0000 Hi Jan, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Saturday, July 15, 2017 12:05 PM > To: Jan Blunck ; dev@dpdk.org > Cc: Doherty, Declan > Subject: Re: [dpdk-dev] [PATCH v2 3/4] cryptodev: rework PMD init to not > require rte_vdev.h >=20 > Hi >=20 > > -----Original Message----- > > From: Jan Blunck [mailto:jblunck@gmail.com] On Behalf Of Jan Blunck > > Sent: Wednesday, July 12, 2017 8:59 PM > > To: dev@dpdk.org > > Cc: Doherty, Declan ; De Lara Guarch, Pablo > > > > Subject: [PATCH v2 3/4] cryptodev: rework PMD init to not require > > rte_vdev.h > > > > The rte_cryptodev_vdev_pmd_init() is a helper for vdev-based drivers. > > By moving the helper to the header we don't require rte_vdev.h at > > build- time of the librte_cryptodev library. This is a preparation to > > move the vdev bus into a standalone library. > > > > Signed-off-by: Jan Blunck >=20 > I am seeing some clang errors when applying this patch: >=20 > lib/librte_cryptodev/rte_cryptodev_vdev.h:88:14: error: implicit > declaration of function 'rte_cryptodev_pmd_allocate' is invalid in C99 [- > Werror,-Wimplicit-function-declaration] > cryptodev =3D rte_cryptodev_pmd_allocate(name, socket_id); > ^ > lib/librte_cryptodev/rte_cryptodev_vdev.h:88:12: error: incompatible > integer to pointer conversion assigning to 'struct rte_cryptodev *' from = 'int' > [-Werror,-Wint-conversion] > cryptodev =3D rte_cryptodev_pmd_allocate(name, socket_id); >=20 > Also, looks like git commit title is not correct, according to check-git-= log.sh: >=20 > Wrong headline format: > cryptodev: rework PMD init to not require rte_vdev.h Would you have time in this release to fix this? Thanks, Pablo >=20 >=20 > Pablo