From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 474F32BBE for ; Mon, 18 Sep 2017 16:24:36 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Sep 2017 07:24:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,413,1500966000"; d="scan'208";a="1015621860" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by orsmga003.jf.intel.com with ESMTP; 18 Sep 2017 07:24:35 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.167]) by irsmsx105.ger.corp.intel.com ([169.254.7.75]) with mapi id 14.03.0319.002; Mon, 18 Sep 2017 15:24:34 +0100 From: "De Lara Guarch, Pablo" To: Akhil Goyal , "dev@dpdk.org" CC: "Doherty, Declan" , "Mcnamara, John" , "hemant.agrawal@nxp.com" Thread-Topic: [PATCH 1/4] bus/dpaa: scan for DPAA Crypto devices Thread-Index: AQHTHGxo9001BfcChEOXtGU235gtIKK62kOA Date: Mon, 18 Sep 2017 14:24:34 +0000 Message-ID: References: <20170824000117.32186-1-akhil.goyal@nxp.com> <20170824000117.32186-2-akhil.goyal@nxp.com> In-Reply-To: <20170824000117.32186-2-akhil.goyal@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNGFlZWZlNzUtNjYwMC00ZmI1LWI5NmEtYzkwYmE2ZDUyYjJkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjRLa2NyUEpoOFk3VkhXa1BkZTh2akhtWTAxd1wvVStkcTZwOHVPMEpja3BvPSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/4] bus/dpaa: scan for DPAA Crypto devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Sep 2017 14:24:37 -0000 > -----Original Message----- > From: Akhil Goyal [mailto:akhil.goyal@nxp.com] > Sent: Thursday, August 24, 2017 1:01 AM > To: dev@dpdk.org; De Lara Guarch, Pablo > > Cc: Doherty, Declan ; Mcnamara, John > ; hemant.agrawal@nxp.com; Akhil Goyal > > Subject: [PATCH 1/4] bus/dpaa: scan for DPAA Crypto devices >=20 > Signed-off-by: Shreyansh Jain > Signed-off-by: Akhil Goyal > --- > config/defconfig_arm64-dpaa-linuxapp-gcc | 3 ++ > drivers/bus/dpaa/dpaa_bus.c | 51 > ++++++++++++++++++++++++++++++++ > 2 files changed, 54 insertions(+) >=20 > diff --git a/config/defconfig_arm64-dpaa-linuxapp-gcc > b/config/defconfig_arm64-dpaa-linuxapp-gcc > index c0f5e4a..7c8cf3c 100644 > --- a/config/defconfig_arm64-dpaa-linuxapp-gcc > +++ b/config/defconfig_arm64-dpaa-linuxapp-gcc > @@ -62,3 +62,6 @@ > CONFIG_RTE_MBUF_DEFAULT_MEMPOOL_OPS=3D"dpaa" > # Compile software NXP DPAA PMD > CONFIG_RTE_LIBRTE_DPAA_PMD=3Dy > CONFIG_RTE_LIBRTE_DPAA_PMD_DEBUG=3Dn > + > +# DPAA CAAM driver instances > +CONFIG_RTE_LIBRTE_DPAA_MAX_CRYPTODEV=3D4 > diff --git a/drivers/bus/dpaa/dpaa_bus.c b/drivers/bus/dpaa/dpaa_bus.c > index 7ae5bfa..18c8d97 100644 > --- a/drivers/bus/dpaa/dpaa_bus.c > +++ b/drivers/bus/dpaa/dpaa_bus.c > @@ -93,6 +93,21 @@ dpaa_remove_from_device_list(struct > rte_dpaa_device *dev) > TAILQ_INSERT_TAIL(&rte_dpaa_bus.device_list, dev, next); } >=20 > +/* Reads the SEC device and ERA from DTS by using the of library Missing a word between "the" and "of"? > + * Returns -1 if SEC devices not available, 0 otherwise */ static > +inline int > +dpaa_sec_available(void) > +{ > + const struct device_node *caam_node; > + > + for_each_compatible_node(caam_node, NULL, "fsl,sec-v4.0") { > + return 0; > + } > + > + return -1; > +} > + > static void dpaa_clean_device_list(void); >=20 > static int > @@ -134,6 +149,42 @@ dpaa_create_device_list(void) >=20 > rte_dpaa_bus.device_count =3D i; >=20 > + /* Unlike case of ETH, RTE_LIBRTE_DPAA_MAX_CRYPTODEV SEC > devices are > + * constantly created only if "sec" property is found in the device > + * tree. Logically there is no limit (QI interfaces), for number of > + * device, that can be created. > + */ I would reword the last sentence, probably removing the commas and changing= "device" for "devices".