From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id EBF651B1BD for ; Fri, 6 Oct 2017 14:52:41 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Oct 2017 05:52:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,483,1500966000"; d="scan'208";a="907422727" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by FMSMGA003.fm.intel.com with ESMTP; 06 Oct 2017 05:52:40 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.167]) by IRSMSX153.ger.corp.intel.com ([169.254.9.34]) with mapi id 14.03.0319.002; Fri, 6 Oct 2017 13:50:31 +0100 From: "De Lara Guarch, Pablo" To: "Doherty, Declan" , "akhil.goyal@nxp.com" CC: "dev@dpdk.org" Thread-Topic: [PATCH v4 0/8] Crypto-perf app improvements Thread-Index: AQHTPQZxaxiaRS/HWEiNPsMAWP96yqLWxFFQ Date: Fri, 6 Oct 2017 12:50:30 +0000 Message-ID: References: <20170922075519.28342-1-pablo.de.lara.guarch@intel.com> <20171004034613.44541-1-pablo.de.lara.guarch@intel.com> In-Reply-To: <20171004034613.44541-1-pablo.de.lara.guarch@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzQzYmM2OGMtN2UzYi00ZDNiLWEwMzItOGZjMzQ1OWQ3N2E4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImNFWGt1YUZ0amRQdkx2bmlCT0NhdU1UWU9kbldJZGpTMHN5dHhVM1hcL0ZvPSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 0/8] Crypto-perf app improvements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Oct 2017 12:52:42 -0000 > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Wednesday, October 4, 2017 4:46 AM > To: Doherty, Declan ; akhil.goyal@nxp.com > Cc: dev@dpdk.org; De Lara Guarch, Pablo > > Subject: [PATCH v4 0/8] Crypto-perf app improvements >=20 > This patchset includes some improvements in the Crypto performance > application, including app fixes and new parameter additions. >=20 > The last patch, in particular, introduces performance improvements. > Currently, crypto operations are allocated in a mempool and mbufs in a > different one. Then mbufs are extracted to an array, which is looped > through for all the crypto operations, impacting greatly the performance,= as > much more memory is used. >=20 > Since crypto operations and mbufs are mapped 1:1, the can share the same > mempool object (similar to having the mbuf in the private data of the > crypto operation). > This improves performance, as it is only required to handle a single > mempool and the mbufs are obtained from the cache of the mempoool, > and not from an static array. >=20 > Changes in v4: > - Refactored test code, to minimize duplications > - Removed --qp-nb parameter. Now the number of queue pairs > per device are calculated from the number of logical cores > available and the number of crypto devices >=20 > Changes in v3: > - Renamed "number of queue pairs" option from "--qps" to "--qp-nb", > for more consistency >=20 > Changes in v2: >=20 > - Added support for multiple queue pairs > - Mempool for crypto operations and mbufs is now created > using rte_mempool_create_empty(), rte_mempool_set_ops_byname(), > rte_mempool_populate_default() and rte_mempool_obj_iter(), > so mempool handler is set, as per Akhil's request. >=20 > Pablo de Lara (8): > app/crypto-perf: refactor common test code > app/crypto-perf: set AAD after the crypto operation > app/crypto-perf: parse AEAD data from vectors > app/crypto-perf: parse segment size > app/crypto-perf: overwrite mbuf when verifying > app/crypto-perf: do not populate the mbufs at init > app/crypto-perf: support multiple queue pairs > app/crypto-perf: use single mempool >=20 > app/test-crypto-perf/Makefile | 5 + > app/test-crypto-perf/cperf_ops.c | 136 ++++++++--- > app/test-crypto-perf/cperf_ops.h | 2 +- > app/test-crypto-perf/cperf_options.h | 5 +- > app/test-crypto-perf/cperf_options_parsing.c | 47 ++-- > app/test-crypto-perf/cperf_test_common.c | 225 > ++++++++++++++++++ > app/test-crypto-perf/cperf_test_common.h | 52 +++++ > app/test-crypto-perf/cperf_test_latency.c | 239 +++--------------= -- > app/test-crypto-perf/cperf_test_pmd_cyclecount.c | 239 ++++-------------= -- > app/test-crypto-perf/cperf_test_throughput.c | 237 +++--------------= -- > app/test-crypto-perf/cperf_test_vector_parsing.c | 55 +++++ > app/test-crypto-perf/cperf_test_verify.c | 278 ++++++-----------= ------ > app/test-crypto-perf/main.c | 100 +++++--- > doc/guides/tools/cryptoperf.rst | 6 +- > 14 files changed, 715 insertions(+), 911 deletions(-) create mode 10064= 4 > app/test-crypto-perf/cperf_test_common.c > create mode 100644 app/test-crypto-perf/cperf_test_common.h >=20 > -- > 2.9.4 Applied to dpdk-next-crypto. Pablo