Re: [dpdk-dev] [PATCH 04/11] examples/ipsec-secgw: Fix aad_len for for aes-gcm support

Re: [dpdk-dev] [PATCH 04/11] examples/ipsec-secgw: Fix aad_len for for aes-gcm support

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: aviadye@mellanox.com [mailto:aviadye@mellanox.com]
> Sent: Saturday, October 14, 2017 2:27 PM
> To: dev@dpdk.org; Gonzalez Monroy, Sergio
> <sergio.gonzalez.monroy@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; aviadye@mellanox.com
> Cc: borisp@mellanox.com; akhil.goyal@nxp.com;
> hemant.agrawal@nxp.com; Nicolau, Radu <radu.nicolau@intel.com>;
> Doherty, Declan <declan.doherty@intel.com>; aviadye@dev.mellanox.co.il;
> liranl@mellanox.com; nelio.laranjeiro@6wind.com; thomas@monjalon.net
> Subject: [dpdk-dev][PATCH 04/11] examples/ipsec-secgw: Fix aad_len for
> for aes-gcm support
> 
> From: Aviad Yehezkel <aviadye@mellanox.com>
> 
> This cause auth failure issue
> Seems like this was broken for aes-gcm for a long time

This last sentence is irrelevant for the commit message.
Better to explain what is broken than how long that has been broken for.

Thanks,
Pablo

Re: [dpdk-dev] [PATCH 11/11] examples/ipsec-secgw: Ethernet MAC configuration is now dynamic throw conf file

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: aviadye@mellanox.com [mailto:aviadye@mellanox.com]
> Sent: Saturday, October 14, 2017 2:27 PM
> To: dev@dpdk.org; Gonzalez Monroy, Sergio
> <sergio.gonzalez.monroy@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; aviadye@mellanox.com
> Cc: borisp@mellanox.com; akhil.goyal@nxp.com;
> hemant.agrawal@nxp.com; Nicolau, Radu <radu.nicolau@intel.com>;
> Doherty, Declan <declan.doherty@intel.com>; aviadye@dev.mellanox.co.il;
> liranl@mellanox.com; nelio.laranjeiro@6wind.com; thomas@monjalon.net
> Subject: [dpdk-dev][PATCH 11/11] examples/ipsec-secgw: Ethernet MAC
> configuration is now dynamic throw conf file
> 
> From: Aviad Yehezkel <aviadye@mellanox.com>
> 
> Signed-off-by: Aviad Yehezkel <aviadye@mellanox.com>

Better to use a shorter commit title (e.g. examples/ipsec-secgw: configure mac dynamically).

Pablo

Re: [dpdk-dev] [PATCH 04/11] examples/ipsec-secgw: Fix aad_len for for aes-gcm support

[Aviad Yehezkel]

On 10/14/2017 4:27 PM, aviadye@dev.mellanox.co.il wrote:
> From: Aviad Yehezkel <aviadye@mellanox.com>
>
> This cause auth failure issue
> Seems like this was broken for aes-gcm for a long time
>
> Signed-off-by: Aviad Yehezkel <aviadye@mellanox.com>
> ---
>   examples/ipsec-secgw/sa.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c
> index 7be0e62..ef94475 100644
> --- a/examples/ipsec-secgw/sa.c
> +++ b/examples/ipsec-secgw/sa.c
> @@ -431,7 +431,7 @@ parse_sa_tokens(char **tokens, uint32_t n_tokens,
>   			rule->aead_algo = algo->algo;
>   			rule->cipher_key_len = algo->key_len;
>   			rule->digest_len = algo->digest_len;
> -			rule->aad_len = algo->key_len;
> +			rule->aad_len = algo->aad_len;
>   			rule->block_size = algo->block_size;
>   			rule->iv_len = algo->iv_len;
>   

Tested-by: Aviad Yehezkel <aviadye@mellanox.com>

[dpdk-dev] [PATCH 04/11] examples/ipsec-secgw: Fix aad_len for for aes-gcm support

[aviadye]

From: Aviad Yehezkel <aviadye@mellanox.com>

This cause auth failure issue
Seems like this was broken for aes-gcm for a long time

Signed-off-by: Aviad Yehezkel <aviadye@mellanox.com>
---
 examples/ipsec-secgw/sa.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c
index 7be0e62..ef94475 100644
--- a/examples/ipsec-secgw/sa.c
+++ b/examples/ipsec-secgw/sa.c
@@ -431,7 +431,7 @@ parse_sa_tokens(char **tokens, uint32_t n_tokens,
 			rule->aead_algo = algo->algo;
 			rule->cipher_key_len = algo->key_len;
 			rule->digest_len = algo->digest_len;
-			rule->aad_len = algo->key_len;
+			rule->aad_len = algo->aad_len;
 			rule->block_size = algo->block_size;
 			rule->iv_len = algo->iv_len;
 
-- 
2.7.4