From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 7AD2523A for ; Wed, 18 Oct 2017 15:10:27 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Oct 2017 06:10:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,396,1503385200"; d="scan'208";a="161882903" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by orsmga005.jf.intel.com with ESMTP; 18 Oct 2017 06:10:25 -0700 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by IRSMSX153.ger.corp.intel.com (163.33.192.75) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 18 Oct 2017 14:10:24 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.167]) by irsmsx155.ger.corp.intel.com ([169.254.14.169]) with mapi id 14.03.0319.002; Wed, 18 Oct 2017 14:10:24 +0100 From: "De Lara Guarch, Pablo" To: "Yang, Zhiyong" , "dev@dpdk.org" CC: "Yigit, Ferruh" , "Yang, Zhiyong" Thread-Topic: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix port id type Thread-Index: AQHTR/aPSJuPilRtR0ONwJSJ8y0CQaLpetVA Date: Wed, 18 Oct 2017 13:10:23 +0000 Message-ID: References: <20171018095019.42807-1-zhiyong.yang@intel.com> In-Reply-To: <20171018095019.42807-1-zhiyong.yang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjAyODQ0Y2YtZGIxYi00OTljLWE5NTItM2MxYTJkM2FjMDEyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjI5XC9URTdPVmlucXJrNTI2OFlhTnMzUzVvQUxzSU9vRFJQRFkxN2ZneURNPSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix port id type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Oct 2017 13:10:27 -0000 Hi Zhiyong, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhiyong Yang > Sent: Wednesday, October 18, 2017 10:50 AM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Yang, Zhiyong > > Subject: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix port id type >=20 > Fix port id issue and remove unnecessary cast. >=20 > Fixes: f8244c6399d9 ("ethdev: increase port id range") > Signed-off-by: Zhiyong Yang Actually, I think we can extend this patch to declare all variables related to port ids to uint16_t. I have seen the following: "l2fwd_dst_ports", "portid", "dest_portid", "dst= _port". Rest of the patch looks good to me, so you can keep the ack if you are doin= g a v2. Acked-by: Pablo de Lara