From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 0A8721B7A4 for ; Tue, 24 Oct 2017 13:18:07 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Oct 2017 04:18:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,427,1503385200"; d="scan'208";a="326999592" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by fmsmga004.fm.intel.com with ESMTP; 24 Oct 2017 04:18:06 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.167]) by IRSMSX153.ger.corp.intel.com ([169.254.9.34]) with mapi id 14.03.0319.002; Tue, 24 Oct 2017 12:18:05 +0100 From: "De Lara Guarch, Pablo" To: "Doherty, Declan" , "dev@dpdk.org" CC: "Doherty, Declan" Thread-Topic: [dpdk-dev] [PATCH 2/3] cryptodev: break dependency on virtual device bus Thread-Index: AQHTSeofyI6FfZ4Pv0iDtLkOvFenuqLy25iA Date: Tue, 24 Oct 2017 11:18:05 +0000 Message-ID: References: <20171020212113.4543-1-declan.doherty@intel.com> <20171020212113.4543-3-declan.doherty@intel.com> In-Reply-To: <20171020212113.4543-3-declan.doherty@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGZlYTgyOWMtNmEyOC00NjY1LWI1N2ItOGI1YjA2MDIxNTUyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlljQWEzbGw1eFwvTzA5SGdxWFVcL3FjVHRzQ05vZUhsRVFkMm8rbXdZOGFQST0ifQ== x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/3] cryptodev: break dependency on virtual device bus X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2017 11:18:08 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Declan Doherty > Sent: Friday, October 20, 2017 10:21 PM > To: dev@dpdk.org > Cc: Doherty, Declan > Subject: [dpdk-dev] [PATCH 2/3] cryptodev: break dependency on virtual > device bus >=20 > Removes any dependency of librte_cryptodev on the virtual device > infrastructure code and removes the functions which were virtual device > specific. >=20 > Updates all virtual PMDs to remove dependencies on rte_cryptodev_vdev.h > and replaces those calls with the new bus independent functions. >=20 > Signed-off-by: Declan Doherty ... > diff --git a/drivers/crypto/snow3g/rte_snow3g_pmd.c > b/drivers/crypto/snow3g/rte_snow3g_pmd.c ... > rte_vdev_device *vdev) static int cryptodev_snow3g_remove(struct > rte_vdev_device *vdev) { > + struct rte_cryptodev *cryptodev; > const char *name; >=20 > name =3D rte_vdev_device_name(vdev); > if (name =3D=3D NULL) > return -EINVAL; >=20 > - RTE_LOG(INFO, PMD, "Closing SNOW 3G crypto device %s" > + RTE_LOG(INFO, PMD, "Closing KASUMI crypto device %s" This should not be changed. ... > +++ b/drivers/crypto/zuc/rte_zuc_pmd.c ... > static int cryptodev_zuc_remove(struct rte_vdev_device *vdev) { > + > + struct rte_cryptodev *cryptodev; > const char *name; >=20 > name =3D rte_vdev_device_name(vdev); > if (name =3D=3D NULL) > return -EINVAL; >=20 > - RTE_LOG(INFO, PMD, "Closing ZUC crypto device %s" > + RTE_LOG(INFO, PMD, "Closing KASUMI crypto device %s" This should not be changed. ... > diff --git a/lib/librte_cryptodev/rte_cryptodev_version.map > b/lib/librte_cryptodev/rte_cryptodev_version.map > index a0ea7bf..d3e4515 100644 > --- a/lib/librte_cryptodev/rte_cryptodev_version.map > +++ b/lib/librte_cryptodev/rte_cryptodev_version.map > @@ -73,8 +73,6 @@ DPDK_17.08 { > rte_cryptodev_sym_capability_check_aead; > rte_cryptodev_sym_session_init; > rte_cryptodev_sym_session_clear; > - rte_cryptodev_vdev_parse_init_params; > - rte_cryptodev_vdev_pmd_init; > rte_crypto_aead_algorithm_strings; > rte_crypto_aead_operation_strings; Release notes should be updated, since these two functions are being remove= d. Also, rte_cryptodev_vdev_pmd_init function was going to be declared static = in this release, so the note in deprecation.rst should be removed. >=20 > -- > 2.9.4