From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pablo.de.lara.guarch@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 03F601B7DB
 for <dev@dpdk.org>; Tue, 24 Oct 2017 17:15:52 +0200 (CEST)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga105.fm.intel.com with ESMTP; 24 Oct 2017 08:15:51 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.43,428,1503385200"; d="scan'208";a="1028780276"
Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155])
 by orsmga003.jf.intel.com with ESMTP; 24 Oct 2017 08:15:48 -0700
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.167]) by
 IRSMSX102.ger.corp.intel.com ([169.254.2.180]) with mapi id 14.03.0319.002;
 Tue, 24 Oct 2017 16:15:48 +0100
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Akhil Goyal <akhil.goyal@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "Doherty, Declan" <declan.doherty@intel.com>, "hemant.agrawal@nxp.com"
 <hemant.agrawal@nxp.com>, "Nicolau, Radu" <radu.nicolau@intel.com>,
 "borisp@mellanox.com" <borisp@mellanox.com>, "aviadye@mellanox.com"
 <aviadye@mellanox.com>, "thomas@monjalon.net" <thomas@monjalon.net>,
 "sandeep.malik@nxp.com" <sandeep.malik@nxp.com>,
 "jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>,
 "Mcnamara, John" <john.mcnamara@intel.com>, "Ananyev, Konstantin"
 <konstantin.ananyev@intel.com>, "shahafs@mellanox.com"
 <shahafs@mellanox.com>, "olivier.matz@6wind.com" <olivier.matz@6wind.com>
Thread-Topic: [PATCH v5 01/11] lib/rte_security: add security library
Thread-Index: AQHTTNMFQK75///voEy9WzJhIKGlwqLzGkaQ
Date: Tue, 24 Oct 2017 15:15:47 +0000
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CC3AD50@IRSMSX108.ger.corp.intel.com>
References: <20171014221734.15511-1-akhil.goyal@nxp.com>
 <20171024141545.30837-1-akhil.goyal@nxp.com>
 <20171024141545.30837-2-akhil.goyal@nxp.com>
In-Reply-To: <20171024141545.30837-2-akhil.goyal@nxp.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNGVhZmUzYTEtOTkyNC00ZDFmLWIyYjEtNjAzYzI3OTBkYTI4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImtjQ05DSm5NTkY5dEFPKzFRb25uQVkwQWZocHdVd3JMSWdEeVFadHdZMEU9In0=
x-ctpclassification: CTP_IC
dlp-product: dlpe-windows
dlp-version: 11.0.0.116
dlp-reaction: no-action
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v5 01/11] lib/rte_security: add security
	library
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Oct 2017 15:15:53 -0000

Hi Akhil,

> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Tuesday, October 24, 2017 3:16 PM
> To: dev@dpdk.org
> Cc: Doherty, Declan <declan.doherty@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; hemant.agrawal@nxp.com; Nicolau,
> Radu <radu.nicolau@intel.com>; borisp@mellanox.com;
> aviadye@mellanox.com; thomas@monjalon.net; sandeep.malik@nxp.com;
> jerin.jacob@caviumnetworks.com; Mcnamara, John
> <john.mcnamara@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; shahafs@mellanox.com;
> olivier.matz@6wind.com
> Subject: [PATCH v5 01/11] lib/rte_security: add security library
>=20

If you are making a v6, I would change the title to "security: ...".
Also, there is an issue described below.

Regards,
Pablo

...

> diff --git a/lib/librte_security/Makefile b/lib/librte_security/Makefile =
new
> file mode 100644 index 0000000..af87bb2
> --- /dev/null
> +++ b/lib/librte_security/Makefile

...

> +
> +# library name
> +LIB =3D librte_security.a
> +
> +# library version
> +LIBABIVER :=3D 1
> +
> +# build flags
> +CFLAGS +=3D -O3
> +CFLAGS +=3D $(WERROR_FLAGS)

There is a compilation issue when the building as shared library, because L=
DLIBS have not been set.

You need to add the following:

+LDLIBS +=3D -lrte_eal -lrte_mempool