From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pablo.de.lara.guarch@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 6E3F21B24E;
 Tue,  7 Nov 2017 18:43:46 +0100 (CET)
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 07 Nov 2017 09:43:19 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.44,359,1505804400"; d="scan'208";a="333303902"
Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66])
 by fmsmga004.fm.intel.com with ESMTP; 07 Nov 2017 09:43:17 -0800
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.167]) by
 IRSMSX152.ger.corp.intel.com ([169.254.6.87]) with mapi id 14.03.0319.002;
 Tue, 7 Nov 2017 17:43:17 +0000
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Ophir Munk <ophirmu@mellanox.com>, "Wu, Jingjing" <jingjing.wu@intel.com>
CC: Gaetan Rivet <gaetan.rivet@6wind.com>, "Ophir Munk <ophirmu@mellanox.com"
 <Ophir Munk <ophirmu@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>, "Thomas
 Monjalon" <thomas@monjalon.net>, Olga Shern <olgas@mellanox.com>,
 "stable@dpdk.org" <stable@dpdk.org>, Raslan Darawsheh <rasland@mellanox.com>
Thread-Topic: [dpdk-stable] [PATCH v2] app/testpmd: fix forwarding between
 non	consecutive ports
Thread-Index: AQHTV8+1gkUZZkuJK0WWOxKeY2SC6aMJL53Q
Date: Tue, 7 Nov 2017 17:43:16 +0000
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CC45FC1@IRSMSX108.ger.corp.intel.com>
References: <1509977954-4333-1-git-send-email-ophirmu@mellanox.com>
 <1510062750-29091-1-git-send-email-ophirmu@mellanox.com>
In-Reply-To: <1510062750-29091-1-git-send-email-ophirmu@mellanox.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDJjYzk3OTYtM2I4Ny00ZGM5LWFlODktMzAwNTRjZjJjMjZkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Ilo4UDlzVXA0QXFpQk9SY0lTa281b2tqS2prSXozYmtJbFVHUkZNQXpoRHM9In0=
x-ctpclassification: CTP_IC
dlp-product: dlpe-windows
dlp-version: 11.0.0.116
dlp-reaction: no-action
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] app/testpmd: fix forwarding
 between non	consecutive ports
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Nov 2017 17:43:47 -0000



> -----Original Message-----
> From: stable [mailto:stable-bounces@dpdk.org] On Behalf Of Ophir Munk
> Sent: Tuesday, November 7, 2017 1:53 PM
> To: Wu, Jingjing <jingjing.wu@intel.com>
> Cc: Gaetan Rivet <gaetan.rivet@6wind.com>; Ophir Munk
> <ophirmu@mellanox.com; dev@dpdk.org; Thomas Monjalon
> <thomas@monjalon.net>; Olga Shern <olgas@mellanox.com>;
> stable@dpdk.org; Raslan Darawsheh <rasland@mellanox.com>
> Subject: [dpdk-stable] [PATCH v2] app/testpmd: fix forwarding between
> non consecutive ports
>=20
> When defining two failsafe devices in testpmd the port numbers of the
> failsafe devices may not be consecutive.
> For example: if failsafe device includes a PCI device and a TAP device th=
en
> failsafe port numbers would be 0 and 3.
> Port 0 - failsafe #1 device
> Port 1 - PCI #1 device
> Port 2 - TAP #1 device
> Port 3 - failsafe #2 device
> Port 4 - PCI #2 device
> Port 5 - TAP #2 device
>=20
> If forwarding is defined between the failsafe devices including a peer
> address the forwarding should be between peer addresses of ports 0 and 3.
> Instead testpmd establishes forwarding between peer addresses of
> consecutive ports 0 and 1. This commit fixes this bug.
>=20
> Fixes: af75078fece3 ("first public release")
> Cc: stable@dpdk.org
>=20
> Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
> Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>

Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>