From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 576CB1B01B for ; Mon, 8 Jan 2018 11:14:21 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Jan 2018 02:14:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,330,1511856000"; d="scan'208";a="22270770" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by orsmga001.jf.intel.com with ESMTP; 08 Jan 2018 02:14:19 -0800 Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by IRSMSX104.ger.corp.intel.com (163.33.3.159) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 8 Jan 2018 10:14:18 +0000 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.167]) by IRSMSX156.ger.corp.intel.com ([169.254.3.33]) with mapi id 14.03.0319.002; Mon, 8 Jan 2018 10:14:18 +0000 From: "De Lara Guarch, Pablo" To: "Nicolau, Radu" , "dev@dpdk.org" CC: "Ananyev, Konstantin" , "Yigit, Ferruh" , "Gonzalez Monroy, Sergio" , "Doherty, Declan" , "akhil.goyal@nxp.com" Thread-Topic: [PATCH 1/3] lib/librte_security: added get size Thread-Index: AQHTc0hzYZPC3kI7A0uofG+ACZrh36Np6Ujg Date: Mon, 8 Jan 2018 10:14:17 +0000 Message-ID: References: <1513083027-11741-1-git-send-email-radu.nicolau@intel.com> In-Reply-To: <1513083027-11741-1-git-send-email-radu.nicolau@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmEwYmI3N2MtYTY2Ny00MDA5LWFhYTctNzRjODExY2YwY2MwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkFlSFZWeEdNdVVvSVBkSkEzYXlTZFZMZ3IrazhmYzNPcmFhcGxyTUJ3ZlU9In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/3] lib/librte_security: added get size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Jan 2018 10:14:21 -0000 > -----Original Message----- > From: Nicolau, Radu > Sent: Tuesday, December 12, 2017 12:50 PM > To: dev@dpdk.org > Cc: Ananyev, Konstantin ; Yigit, Ferruh > ; Gonzalez Monroy, Sergio > ; De Lara Guarch, Pablo > ; Doherty, Declan > ; akhil.goyal@nxp.com; Nicolau, Radu > > Subject: [PATCH 1/3] lib/librte_security: added get size Title should be "security: add get session size function", or something sim= ilar (use verb in infinitive form). Secondly, I would add a short description of what this is doing. Also, I have a comment inline in the code below. Lastly, if any of the maintainers of the security library has any problems = with this patch, please shout. >=20 > Signed-off-by: Radu Nicolau > --- > lib/librte_security/rte_security.c | 7 +++++++ > lib/librte_security/rte_security.h | 12 ++++++++++++ > lib/librte_security/rte_security_driver.h | 14 ++++++++++++++ > lib/librte_security/rte_security_version.map | 1 + > 4 files changed, 34 insertions(+) >=20 > diff --git a/lib/librte_security/rte_security.c > b/lib/librte_security/rte_security.c > index 1227fca..56f2345 100644 > --- a/lib/librte_security/rte_security.c > +++ b/lib/librte_security/rte_security.c > @@ -70,6 +70,13 @@ rte_security_session_update(struct rte_security_ctx > *instance, > return instance->ops->session_update(instance->device, sess, conf); > } >=20 > +unsigned int > +rte_security_session_get_size(struct rte_security_ctx *instance) { > + RTE_FUNC_PTR_OR_ERR_RET(*instance->ops->session_get_size, 0); > + return instance->ops->session_get_size(instance->device); Session get size returns an "int", but this function returns "unsigned int"= , I think they should be the same type. Thanks, Pablo