From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id DA8331322C for ; Mon, 8 Jan 2018 18:36:11 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Jan 2018 09:36:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,330,1511856000"; d="scan'208";a="8092940" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by fmsmga007.fm.intel.com with ESMTP; 08 Jan 2018 09:36:09 -0800 Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by IRSMSX107.ger.corp.intel.com (163.33.3.99) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 8 Jan 2018 17:36:08 +0000 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.167]) by IRSMSX156.ger.corp.intel.com ([169.254.3.33]) with mapi id 14.03.0319.002; Mon, 8 Jan 2018 17:36:08 +0000 From: "De Lara Guarch, Pablo" To: Ravi Kumar , "dev@dpdk.org" Thread-Topic: [PATCH v2 17/20] crypto/ccp: add cpu based md5 and sha2 family auth algo support Thread-Index: AQHThglL3p3FiOxVdk6ckAQ/xAO+/qNqQZYA Date: Mon, 8 Jan 2018 17:36:07 +0000 Message-ID: References: <1512047553-118101-1-git-send-email-Ravi1.kumar@amd.com> <1515145198-97367-1-git-send-email-Ravi1.kumar@amd.com> <1515145198-97367-17-git-send-email-Ravi1.kumar@amd.com> In-Reply-To: <1515145198-97367-17-git-send-email-Ravi1.kumar@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODUwZTZlN2QtMDM4ZC00NjdmLWI0OGQtZTQ1YzdjZDg2NDI0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkZacTZ3d1hnNUwwOTZZYk0xSkNQRTFNeWhPZjQxVWo2SHd3K1ZcL0I1d1lVPSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 17/20] crypto/ccp: add cpu based md5 and sha2 family auth algo support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Jan 2018 17:36:13 -0000 Hi Ravi, > -----Original Message----- > From: Ravi Kumar [mailto:Ravi1.kumar@amd.com] > Sent: Friday, January 5, 2018 9:40 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo > Subject: [PATCH v2 17/20] crypto/ccp: add cpu based md5 and sha2 family > auth algo support >=20 > Auth operations can be performed on CPU without offloading to CCP if > CONFIG_RTE_LIBRTE_PMD_CCP_CPU_AUTH is enabled in DPDK > configuration. >=20 > Signed-off-by: Ravi Kumar ... > --- a/drivers/crypto/ccp/ccp_crypto.c > +++ b/drivers/crypto/ccp/ccp_crypto.c ... > } >=20 > @@ -2638,13 +2874,23 @@ static inline void ccp_auth_dq_prepare(struct > rte_crypto_op *op) } >=20 > static int > -ccp_prepare_ops(struct rte_crypto_op **op_d, > +ccp_prepare_ops(struct ccp_qp *qp, There is a compilation error if the PMD is enabled and CONFIG_RTE_LIBRTE_PMD_CCP_CPU_AUTH=3Dn. You need to set the struct ccp_qp *qp parameter as __rte_unused, in case this option is not enabled. Pablo