From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id BFC431B687 for ; Fri, 26 Jan 2018 12:08:21 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jan 2018 03:08:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,415,1511856000"; d="scan'208";a="22492202" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by orsmga003.jf.intel.com with ESMTP; 26 Jan 2018 03:08:18 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.9]) by IRSMSX106.ger.corp.intel.com ([169.254.8.62]) with mapi id 14.03.0319.002; Fri, 26 Jan 2018 11:08:17 +0000 From: "De Lara Guarch, Pablo" To: "Trahe, Fiona" , "akhil.goyal@nxp.com" , "hemant.agrawal@nxp.com" , "Doherty, Declan" , "Griffin, John" , "Jain, Deepak K" , "jck@semihalf.com" , "tdu@semihalf.com" , "dima@marvell.com" , "nsamsono@marvell.com" , "jianbo.liu@arm.com" , "jerin.jacob@caviumnetworks.com" CC: "dev@dpdk.org" Thread-Topic: [PATCH] doc: announce ABI change for crypto info struct Thread-Index: AQHTloSi5zN7m9cHoUC9uAStPnmqoaOF+E4AgAADYhA= Date: Fri, 26 Jan 2018 11:08:17 +0000 Message-ID: References: <20180126090355.25903-1-pablo.de.lara.guarch@intel.com> <348A99DA5F5B7549AA880327E580B4358930FDD1@IRSMSX101.ger.corp.intel.com> In-Reply-To: <348A99DA5F5B7549AA880327E580B4358930FDD1@IRSMSX101.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTMyZGRjNjgtYzRkZC00YWIxLTkyOTAtZjc3ZTczZjhjOWM5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkI3bHRDU3NkeHByNTdIWThMb0FtTjVjMUR2RmZjT0tMcElOS2hEb01DS009In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for crypto info struct X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2018 11:08:22 -0000 > -----Original Message----- > From: Trahe, Fiona > Sent: Friday, January 26, 2018 10:45 AM > To: De Lara Guarch, Pablo ; > akhil.goyal@nxp.com; hemant.agrawal@nxp.com; Doherty, Declan > ; jerin.jacob@intel.com; Griffin, John > ; Jain, Deepak K ; > jck@semihalf.com; tdu@semihalf.com; dima@marvell.com; > nsamsono@marvell.com; jianbo.liu@arm.com > Cc: dev@dpdk.org; Trahe, Fiona > Subject: RE: [PATCH] doc: announce ABI change for crypto info struct >=20 > Hi Pablo, >=20 > > -----Original Message----- > > From: De Lara Guarch, Pablo > > Sent: Friday, January 26, 2018 9:04 AM > > To: akhil.goyal@nxp.com; hemant.agrawal@nxp.com; Doherty, Declan > > ; jerin.jacob@intel.com; Trahe, Fiona > > ; Griffin, John ; Jain, > > Deepak K ; jck@semihalf.com; > > tdu@semihalf.com; dima@marvell.com; nsamsono@marvell.com; > > jianbo.liu@arm.com > > Cc: dev@dpdk.org; De Lara Guarch, Pablo > > > > Subject: [PATCH] doc: announce ABI change for crypto info struct > > > > Since the API changes made in 17.08, the session mempool is not > > created anymore in each crypto device. > > Therefore, there is no need to have, in the cryptodev info structure, > > the maximum number of sessions supported per device and per queue > > pair. > > > > Signed-off-by: Pablo de Lara > > --- > > doc/guides/rel_notes/deprecation.rst | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/doc/guides/rel_notes/deprecation.rst > > b/doc/guides/rel_notes/deprecation.rst > > index d59ad5988..5588ba7c1 100644 > > --- a/doc/guides/rel_notes/deprecation.rst > > +++ b/doc/guides/rel_notes/deprecation.rst > > @@ -59,3 +59,8 @@ Deprecation Notices > > be added between the producer and consumer structures. The size of > the > > structure and the offset of the fields will remain the same on > > platforms with 64B cache line, but will change on other platforms. > > + > > +* cryptodev: The structure ``sym``, including its fields > > +``max_nb_sessions`` > > + and ``max_nb_sessions_per_qp``, in structure > > +``rte_cryptodev_info``, > > + will be removed in 18.05, as these fields are not relevant anymore > > + since the session mempool is not internal in the crypto device > anymore. > > -- > [Fiona] max_nb_sessions must be also removed from struct > rte_cryptodev_pmd_init_params=20 Good point. Since this structure is internal, I guess we don't need a depre= cation notice for it,=20 but I will remove it in the patch for 18.05. > Regards deprecation of max_nb_sessions from both structs: > Acked-by: Fiona Trahe >=20 > If removing the max_nb_sessions_per_qp, then the following functions > should also be deprecated. > rte_cryptodev_queue_pair_attach_sym_session > rte_cryptodev_queue_pair_detach_sym_session > These and the max_nb_session_per_qp were added here at request of NXP: > http://dpdk.org/ml/archives/dev/2017-March/060740.html Akhil, do you agree on this change? Thanks, Pablo