From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 9DB301B2F4 for ; Mon, 5 Feb 2018 16:57:42 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Feb 2018 07:57:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,465,1511856000"; d="scan'208";a="15980129" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by orsmga006.jf.intel.com with ESMTP; 05 Feb 2018 07:57:40 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.9]) by IRSMSX104.ger.corp.intel.com ([169.254.5.101]) with mapi id 14.03.0319.002; Mon, 5 Feb 2018 15:54:42 +0000 From: "De Lara Guarch, Pablo" To: "Varghese, Vipin" , "dev@dpdk.org" , "Kovacevic, Marko" CC: "Mcnamara, John" , "Varghese, Vipin" Thread-Topic: [dpdk-dev] [PATCH] doc: update multiple instance info for NULL crypto Thread-Index: AQHTno4jGezCd8WoYUe0cz6rqXGbU6OV9SQA Date: Mon, 5 Feb 2018 15:54:42 +0000 Message-ID: References: <1517841119-9277-1-git-send-email-vipin.varghese@intel.com> In-Reply-To: <1517841119-9277-1-git-send-email-vipin.varghese@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiN2ZmNTk4NzEtZjQ5MC00ZjNlLTkyYjQtYTRmYWFiM2I4M2ExIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Ikc4RzhMWlUwM3VIcVdcLzUwM0ozV3VtNFkwUHNUTjliQURXdldrNWN0QXZrPSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] doc: update multiple instance info for NULL crypto X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2018 15:57:43 -0000 Hi Vipin, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Vipin Varghese > Sent: Monday, February 5, 2018 2:32 PM > To: dev@dpdk.org; Kovacevic, Marko > Cc: Mcnamara, John ; Varghese, Vipin > > Subject: [dpdk-dev] [PATCH] doc: update multiple instance info for NULL > crypto >=20 > Add foot note & example to inform user how to use multiple instance. >=20 > Signed-off-by: Vipin Varghese > --- > doc/guides/cryptodevs/null.rst | 20 +++++++++++++++++--- > 1 file changed, 17 insertions(+), 3 deletions(-) >=20 > diff --git a/doc/guides/cryptodevs/null.rst b/doc/guides/cryptodevs/null.= rst > index 03a3ddc..b7072b0 100644 > --- a/doc/guides/cryptodevs/null.rst > +++ b/doc/guides/cryptodevs/null.rst > @@ -41,6 +41,11 @@ each mbuf in the burst will be enqueued in an > internal buffer for collection on a dequeue call as long as the mbuf has= a > valid rte_mbuf_offload operation with a valid rte_cryptodev_session or > rte_crypto_xform chain of operations. >=20 > +.. Note:: > + > + In case of multiple instances of NULL cryptos, each instance should = be of > + unique id. I would use "NULL crypto PMDs". > + > Features > -------- >=20 > @@ -91,7 +96,16 @@ The following parameters (all optional) can be > provided in the previous two call >=20 > Example: >=20 > -.. code-block:: console > +Single vdev instance:: > + > + ./l2fwd-crypto -l 1 -n 4 \ > + --vdev=3D"crypto_null,socket_id=3D0,max_nb_sessions=3D128" \ > + -- -p 1 --cdev SW --chain CIPHER_ONLY --cipher_algo "null" > + > +Multiple vdev instance:: "instances". > + > + ./l2fwd-crypto -l 1-2 -n 4 \ > + --vdev=3D"crypto_null_0,socket_id=3D0,max_nb_sessions=3D128" \ > + --vdev=3D"crypto_null_1,socket_id=3D1,max_nb_sessions=3D128" \ > + -- -p 0x3 --cdev SW --chain CIPHER_HASH --cipher_algo null > + --auth_algo null >=20 > - ./l2fwd-crypto -l 1 -n 4 -- > vdev=3D"crypto_null,socket_id=3D0,max_nb_sessions=3D128" \ > - -- -p 1 --cdev SW --chain CIPHER_ONLY --cipher_algo "null" > -- > 1.9.1 This looks good to me, but I think this can be extended to other PMDs, not = just NULL crypto. Could you send another version, changing the other guides (for the SW based= drivers)? Thanks, Pablo