From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id B8A9A1B61E for ; Mon, 5 Feb 2018 16:58:13 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Feb 2018 07:58:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,465,1511856000"; d="scan'208";a="171792289" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by orsmga004.jf.intel.com with ESMTP; 05 Feb 2018 07:58:12 -0800 Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by IRSMSX106.ger.corp.intel.com (163.33.3.31) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 5 Feb 2018 15:58:11 +0000 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.9]) by IRSMSX156.ger.corp.intel.com ([169.254.3.153]) with mapi id 14.03.0319.002; Mon, 5 Feb 2018 15:58:11 +0000 From: "De Lara Guarch, Pablo" To: "Varghese, Vipin" , "dev@dpdk.org" , "Kovacevic, Marko" CC: "Mcnamara, John" , "Varghese, Vipin" Thread-Topic: [dpdk-dev] [PATCH] doc: update info on multi crypto instances Thread-Index: AQHTno6yUEU9o8Jr1kO8hx5N6VwY/KOV9j6A Date: Mon, 5 Feb 2018 15:58:09 +0000 Message-ID: References: <1517841347-9340-1-git-send-email-vipin.varghese@intel.com> In-Reply-To: <1517841347-9340-1-git-send-email-vipin.varghese@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTNkMjJhZTItMjNlZS00YjExLTg1YzYtYWRhNjllMDZlY2UxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InhiMkt6bUpQMEJHaExEYUR6VFNMTk9tdzdQSlYyR2FrUDRjSWY3RGdDbzQ9In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] doc: update info on multi crypto instances X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2018 15:58:14 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Vipin Varghese > Sent: Monday, February 5, 2018 2:36 PM > To: dev@dpdk.org; Kovacevic, Marko > Cc: Mcnamara, John ; Varghese, Vipin > > Subject: [dpdk-dev] [PATCH] doc: update info on multi crypto instances >=20 > Added note section to update information for use cases working with > multiple crypto devices. I would change the title to something more generic, since you are adding other info and not just the multi crypto device issue. >=20 > Signed-off-by: Vipin Varghese > --- > doc/guides/sample_app_ug/l2_forward_crypto.rst | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/doc/guides/sample_app_ug/l2_forward_crypto.rst > b/doc/guides/sample_app_ug/l2_forward_crypto.rst > index 1e85b4a..c2e6128 100644 > --- a/doc/guides/sample_app_ug/l2_forward_crypto.rst > +++ b/doc/guides/sample_app_ug/l2_forward_crypto.rst > @@ -199,6 +199,14 @@ To run the application in linuxapp environment > with 2 lcores, 2 ports and 2 cryp Refer to the *DPDK Getting Started > Guide* for general information on running applications and the > Environment Abstraction Layer (EAL) options. >=20 > +.. Note:: > + > + * The ``l2fwd-crypto`` sample application requires IPv4 packets for > crypto operation. > + > + * If multiple Ethernet ports is passed, then equal number of crypto > devices are to be passed. > + > + * All crypto devices should use the same session. I would change "should" for "shall" or "will", since the app only supports = one session. > + > Explanation > ----------- >=20 > -- > 1.9.1 Thanks, Pablo