* [dpdk-dev] [PATCH] doc: update info on multi crypto instances @ 2018-02-05 14:35 Vipin Varghese 2018-02-05 15:58 ` De Lara Guarch, Pablo 2018-02-05 17:32 ` [dpdk-dev] [PATCH v2] doc: update application minimum requirement info Vipin Varghese 0 siblings, 2 replies; 7+ messages in thread From: Vipin Varghese @ 2018-02-05 14:35 UTC (permalink / raw) To: dev, marko.kovacevic; +Cc: john.mcnamara, Vipin Varghese Added note section to update information for use cases working with multiple crypto devices. Signed-off-by: Vipin Varghese <vipin.varghese@intel.com> --- doc/guides/sample_app_ug/l2_forward_crypto.rst | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/doc/guides/sample_app_ug/l2_forward_crypto.rst b/doc/guides/sample_app_ug/l2_forward_crypto.rst index 1e85b4a..c2e6128 100644 --- a/doc/guides/sample_app_ug/l2_forward_crypto.rst +++ b/doc/guides/sample_app_ug/l2_forward_crypto.rst @@ -199,6 +199,14 @@ To run the application in linuxapp environment with 2 lcores, 2 ports and 2 cryp Refer to the *DPDK Getting Started Guide* for general information on running applications and the Environment Abstraction Layer (EAL) options. +.. Note:: + + * The ``l2fwd-crypto`` sample application requires IPv4 packets for crypto operation. + + * If multiple Ethernet ports is passed, then equal number of crypto devices are to be passed. + + * All crypto devices should use the same session. + Explanation ----------- -- 1.9.1 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: update info on multi crypto instances 2018-02-05 14:35 [dpdk-dev] [PATCH] doc: update info on multi crypto instances Vipin Varghese @ 2018-02-05 15:58 ` De Lara Guarch, Pablo 2018-02-06 12:04 ` Mcnamara, John 2018-02-05 17:32 ` [dpdk-dev] [PATCH v2] doc: update application minimum requirement info Vipin Varghese 1 sibling, 1 reply; 7+ messages in thread From: De Lara Guarch, Pablo @ 2018-02-05 15:58 UTC (permalink / raw) To: Varghese, Vipin, dev, Kovacevic, Marko; +Cc: Mcnamara, John, Varghese, Vipin > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Vipin Varghese > Sent: Monday, February 5, 2018 2:36 PM > To: dev@dpdk.org; Kovacevic, Marko <marko.kovacevic@intel.com> > Cc: Mcnamara, John <john.mcnamara@intel.com>; Varghese, Vipin > <vipin.varghese@intel.com> > Subject: [dpdk-dev] [PATCH] doc: update info on multi crypto instances > > Added note section to update information for use cases working with > multiple crypto devices. I would change the title to something more generic, since you are adding other info and not just the multi crypto device issue. > > Signed-off-by: Vipin Varghese <vipin.varghese@intel.com> > --- > doc/guides/sample_app_ug/l2_forward_crypto.rst | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/doc/guides/sample_app_ug/l2_forward_crypto.rst > b/doc/guides/sample_app_ug/l2_forward_crypto.rst > index 1e85b4a..c2e6128 100644 > --- a/doc/guides/sample_app_ug/l2_forward_crypto.rst > +++ b/doc/guides/sample_app_ug/l2_forward_crypto.rst > @@ -199,6 +199,14 @@ To run the application in linuxapp environment > with 2 lcores, 2 ports and 2 cryp Refer to the *DPDK Getting Started > Guide* for general information on running applications and the > Environment Abstraction Layer (EAL) options. > > +.. Note:: > + > + * The ``l2fwd-crypto`` sample application requires IPv4 packets for > crypto operation. > + > + * If multiple Ethernet ports is passed, then equal number of crypto > devices are to be passed. > + > + * All crypto devices should use the same session. I would change "should" for "shall" or "will", since the app only supports one session. > + > Explanation > ----------- > > -- > 1.9.1 Thanks, Pablo ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: update info on multi crypto instances 2018-02-05 15:58 ` De Lara Guarch, Pablo @ 2018-02-06 12:04 ` Mcnamara, John 0 siblings, 0 replies; 7+ messages in thread From: Mcnamara, John @ 2018-02-06 12:04 UTC (permalink / raw) To: De Lara Guarch, Pablo, Varghese, Vipin, dev, Kovacevic, Marko Cc: Varghese, Vipin > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Monday, February 5, 2018 3:58 PM > To: Varghese, Vipin <vipin.varghese@intel.com>; dev@dpdk.org; Kovacevic, > Marko <marko.kovacevic@intel.com> > Cc: Mcnamara, John <john.mcnamara@intel.com>; Varghese, Vipin > <vipin.varghese@intel.com> > Subject: RE: [dpdk-dev] [PATCH] doc: update info on multi crypto instances > > > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Vipin Varghese > > Sent: Monday, February 5, 2018 2:36 PM > > To: dev@dpdk.org; Kovacevic, Marko <marko.kovacevic@intel.com> > > Cc: Mcnamara, John <john.mcnamara@intel.com>; Varghese, Vipin > > <vipin.varghese@intel.com> > > Subject: [dpdk-dev] [PATCH] doc: update info on multi crypto instances > > > > Added note section to update information for use cases working with > > multiple crypto devices. > > I would change the title to something more generic, since you are adding > other info and not just the multi crypto device issue. > > > > > Signed-off-by: Vipin Varghese <vipin.varghese@intel.com> > > --- > > doc/guides/sample_app_ug/l2_forward_crypto.rst | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/doc/guides/sample_app_ug/l2_forward_crypto.rst > > b/doc/guides/sample_app_ug/l2_forward_crypto.rst > > index 1e85b4a..c2e6128 100644 > > --- a/doc/guides/sample_app_ug/l2_forward_crypto.rst > > +++ b/doc/guides/sample_app_ug/l2_forward_crypto.rst > > @@ -199,6 +199,14 @@ To run the application in linuxapp environment > > with 2 lcores, 2 ports and 2 cryp Refer to the *DPDK Getting Started > > Guide* for general information on running applications and the > > Environment Abstraction Layer (EAL) options. > > > > +.. Note:: > > + > > + * The ``l2fwd-crypto`` sample application requires IPv4 packets > > + for > > crypto operation. > > + > > + * If multiple Ethernet ports is passed, then equal number of > > + crypto devices are to be passed. Probably better as: If multiple Ethernet ports are passed then an equal number of crypto devices must be passed. ^ permalink raw reply [flat|nested] 7+ messages in thread
* [dpdk-dev] [PATCH v2] doc: update application minimum requirement info 2018-02-05 14:35 [dpdk-dev] [PATCH] doc: update info on multi crypto instances Vipin Varghese 2018-02-05 15:58 ` De Lara Guarch, Pablo @ 2018-02-05 17:32 ` Vipin Varghese 2018-02-06 12:00 ` Mcnamara, John 2018-02-06 16:35 ` De Lara Guarch, Pablo 1 sibling, 2 replies; 7+ messages in thread From: Vipin Varghese @ 2018-02-05 17:32 UTC (permalink / raw) To: dev, marko.kovacevic, pablo.de.lara.guarch; +Cc: john.mcnamara, Vipin Varghese Added note section to update information for use cases working with multiple crypto devices. Signed-off-by: Vipin Varghese <vipin.varghese@intel.com> --- V2 changes: - updated the title from 'info on multi crypto instances' - Pablo - reframed affirmative word 'should' to 'shall' - pablo --- doc/guides/sample_app_ug/l2_forward_crypto.rst | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/doc/guides/sample_app_ug/l2_forward_crypto.rst b/doc/guides/sample_app_ug/l2_forward_crypto.rst index 1e85b4a..fddfd1b 100644 --- a/doc/guides/sample_app_ug/l2_forward_crypto.rst +++ b/doc/guides/sample_app_ug/l2_forward_crypto.rst @@ -199,6 +199,14 @@ To run the application in linuxapp environment with 2 lcores, 2 ports and 2 cryp Refer to the *DPDK Getting Started Guide* for general information on running applications and the Environment Abstraction Layer (EAL) options. +.. Note:: + + * The ``l2fwd-crypto`` sample application requires IPv4 packets for crypto operation. + + * If multiple Ethernet ports is passed, then equal number of crypto devices are to be passed. + + * All crypto devices shall use the same session. + Explanation ----------- -- 1.9.1 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH v2] doc: update application minimum requirement info 2018-02-05 17:32 ` [dpdk-dev] [PATCH v2] doc: update application minimum requirement info Vipin Varghese @ 2018-02-06 12:00 ` Mcnamara, John 2018-02-06 16:35 ` De Lara Guarch, Pablo 1 sibling, 0 replies; 7+ messages in thread From: Mcnamara, John @ 2018-02-06 12:00 UTC (permalink / raw) To: Varghese, Vipin, dev, Kovacevic, Marko, De Lara Guarch, Pablo > -----Original Message----- > From: Varghese, Vipin > Sent: Monday, February 5, 2018 5:32 PM > To: dev@dpdk.org; Kovacevic, Marko <marko.kovacevic@intel.com>; De Lara > Guarch, Pablo <pablo.de.lara.guarch@intel.com> > Cc: Mcnamara, John <john.mcnamara@intel.com>; Varghese, Vipin > <vipin.varghese@intel.com> > Subject: [PATCH v2] doc: update application minimum requirement info > > Added note section to update information for use cases working with > multiple crypto devices. > Acked-by: John McNamara <john.mcnamara@intel.com> ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH v2] doc: update application minimum requirement info 2018-02-05 17:32 ` [dpdk-dev] [PATCH v2] doc: update application minimum requirement info Vipin Varghese 2018-02-06 12:00 ` Mcnamara, John @ 2018-02-06 16:35 ` De Lara Guarch, Pablo 2018-02-06 21:28 ` Thomas Monjalon 1 sibling, 1 reply; 7+ messages in thread From: De Lara Guarch, Pablo @ 2018-02-06 16:35 UTC (permalink / raw) To: Varghese, Vipin, dev, Kovacevic, Marko; +Cc: Mcnamara, John > -----Original Message----- > From: Varghese, Vipin > Sent: Monday, February 5, 2018 5:32 PM > To: dev@dpdk.org; Kovacevic, Marko <marko.kovacevic@intel.com>; De > Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com> > Cc: Mcnamara, John <john.mcnamara@intel.com>; Varghese, Vipin > <vipin.varghese@intel.com> > Subject: [PATCH v2] doc: update application minimum requirement info > > Added note section to update information for use cases working with > multiple crypto devices. > > Signed-off-by: Vipin Varghese <vipin.varghese@intel.com> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH v2] doc: update application minimum requirement info 2018-02-06 16:35 ` De Lara Guarch, Pablo @ 2018-02-06 21:28 ` Thomas Monjalon 0 siblings, 0 replies; 7+ messages in thread From: Thomas Monjalon @ 2018-02-06 21:28 UTC (permalink / raw) To: Varghese, Vipin Cc: dev, De Lara Guarch, Pablo, Kovacevic, Marko, Mcnamara, John > > Added note section to update information for use cases working with > > multiple crypto devices. > > > > Signed-off-by: Vipin Varghese <vipin.varghese@intel.com> > > Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> Applied, thanks ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-02-06 21:28 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-02-05 14:35 [dpdk-dev] [PATCH] doc: update info on multi crypto instances Vipin Varghese 2018-02-05 15:58 ` De Lara Guarch, Pablo 2018-02-06 12:04 ` Mcnamara, John 2018-02-05 17:32 ` [dpdk-dev] [PATCH v2] doc: update application minimum requirement info Vipin Varghese 2018-02-06 12:00 ` Mcnamara, John 2018-02-06 16:35 ` De Lara Guarch, Pablo 2018-02-06 21:28 ` Thomas Monjalon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).