From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 20CFFA84C for ; Tue, 13 Feb 2018 15:53:46 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Feb 2018 06:53:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,507,1511856000"; d="scan'208";a="17386864" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by fmsmga007.fm.intel.com with ESMTP; 13 Feb 2018 06:53:44 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.9]) by IRSMSX152.ger.corp.intel.com ([169.254.6.52]) with mapi id 14.03.0319.002; Tue, 13 Feb 2018 14:53:43 +0000 From: "De Lara Guarch, Pablo" To: "Gujjar, Abhinandan S" , "Doherty, Declan" , "akhil.goyal@nxp.com" , "Jerin.JacobKollanukkaran@cavium.com" CC: "dev@dpdk.org" , "Vangati, Narender" , "Rao, Nikhil" Thread-Topic: [RFC v3, 1/3] cryptodev: set private data for session-less mode Thread-Index: AQHTmz9TrV/ei/JEbkuznUZ9iZ7Sg6OieYSQ Date: Tue, 13 Feb 2018 14:53:42 +0000 Message-ID: References: <1517477405-169206-1-git-send-email-abhinandan.gujjar@intel.com> In-Reply-To: <1517477405-169206-1-git-send-email-abhinandan.gujjar@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjhiMzk0MzktMGY0ZC00NDEyLWE2ODEtODgyZjczYzMxNjZlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InFuR1JcL3RmZGpXaVhwazFwWFB4enp1MWQycFg4bXZjN3hjelZldGtWNEw0PSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [RFC v3, 1/3] cryptodev: set private data for session-less mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Feb 2018 14:53:47 -0000 Hi, > -----Original Message----- > From: Gujjar, Abhinandan S > Sent: Thursday, February 1, 2018 9:30 AM > To: Doherty, Declan ; akhil.goyal@nxp.com; De > Lara Guarch, Pablo ; > Jerin.JacobKollanukkaran@cavium.com > Cc: dev@dpdk.org; Vangati, Narender ; > Gujjar, Abhinandan S ; Rao, Nikhil > > Subject: [RFC v3, 1/3] cryptodev: set private data for session-less mode >=20 > The application may want to store private data along with the > rte_crypto_op that is transparent to the rte_cryptodev layer. > For e.g., If an eventdev based application is submitting a crypto session= -less > operation and wants to indicate event information required to construct a > new event that will be enqueued to eventdev after completion of the crypt= o > operation. This patch provides a mechanism for the application to associa= te > this information with the rte_crypto_op in session-less mode. >=20 > Signed-off-by: Abhinandan Gujjar > Signed-off-by: Nikhil Rao > --- > Notes: > V3: > 1. Added separate patch for session-less private data > 2. Added more information on offset > V2: > 1. Removed enum rte_crypto_op_private_data_type > 2. Corrected formatting >=20 > lib/librte_cryptodev/rte_crypto.h | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) >=20 > diff --git a/lib/librte_cryptodev/rte_crypto.h > b/lib/librte_cryptodev/rte_crypto.h > index 95cf861..2540426 100644 > --- a/lib/librte_cryptodev/rte_crypto.h > +++ b/lib/librte_cryptodev/rte_crypto.h > @@ -84,8 +84,14 @@ struct rte_crypto_op { > */ > uint8_t sess_type; > /**< operation session type */ > + uint16_t private_data_offset; > + /**< Offset to indicate start of private data (if any). The offset > + * is counted from the start of the rte_crypto_op including IV. I assume that if this offset is 0, it means that there is no private data? Also, I would reword the Doxygen comment a bit (here is my suggestion, whic= h looks a bit long, but I hope it is descriptive). " Offset to indicate start of private data (if any). The offset is counted = from the start of the rte_crypto_op structure. The private data may be used by the application to store information which = should remain untouched in the library/driver. Note that an Initialization Vector (IV) for the operation may be placed at = the end of the structure as well, so caution to avoid overwrites has to be = taken." > + * The private data may be used by the application to store > + * information which should remain untouched in the library/driver > + */ >=20 > - uint8_t reserved[5]; > + uint8_t reserved[3]; > /**< Reserved bytes to fill 64 bits for future additions */ > struct rte_mempool *mempool; > /**< crypto operation mempool which operation is allocated from > */ > -- > 1.9.1 Apart from the comments above, this overall looks good to me. I would say you could submit a v1 with some implementation. Could you also modify the Cryptodev section in the Programmer's Guide docum= ent, to reflect these changes? Thanks, Pablo